Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 9374020: mac: Remove InitWebCoreSystemInterface() calls from many random places. (Closed)

Created:
8 years, 10 months ago by Nico
Modified:
8 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org
Visibility:
Public.

Description

mac: Remove InitWebCoreSystemInterface() calls from many random places. This is now done at the webkit api layer (https://bugs.webkit.org/show_bug.cgi?id=78246), so clients no longer have to explicitly do this. Fixes 2 TODOs, helps with the mac component build, and removes a direct WebCore dependency from client code. BUG=90078 TEST=none TBR=tony,brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M chrome/app/chrome_main_delegate.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M content/ppapi_plugin/ppapi_plugin_main.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_mac.mm View 2 chunks +0 lines, -4 lines 0 comments Download
M content/test/render_view_fake_resources_test.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M webkit/support/platform_support_mac.mm View 2 chunks +0 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/test_shell_platform_delegate_mac.mm View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Avi (use Gerrit)
lgtm
8 years, 10 months ago (2012-02-09 17:59:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9374020/1
8 years, 10 months ago (2012-02-14 18:48:20 UTC) #2
commit-bot: I haz the power
Presubmit check for 9374020-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-14 18:48:24 UTC) #3
Nico
tony: webkit/ OWNERS brettw: content/ppapi_plugin/ OWNERS
8 years, 10 months ago (2012-02-14 18:51:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9374020/1
8 years, 10 months ago (2012-02-14 18:51:44 UTC) #5
tony
LGTM!
8 years, 10 months ago (2012-02-14 20:31:27 UTC) #6
commit-bot: I haz the power
8 years, 10 months ago (2012-02-14 20:53:12 UTC) #7
Change committed as 121930

Powered by Google App Engine
This is Rietveld 408576698