Handlify GetSourceCode-related functions.

Handlify GetSourceCode-related functions.

Committed: https://code.google.com/p/v8/source/detail?r=10658

[Kevin Millikin (Chromium), 2012-02-09 08:01:50]

Drive by comment.

http://codereview.chromium.org/9374013/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/9374013/diff/1/src/objects.cc#newcode7620
src/objects.cc:7620: return
Handle<Object>(GetIsolate()->heap()->undefined_value());
You should write this as

return GetIsolate()->factory()->undefined_value();

[Sven Panne, 2012-02-09 08:17:48]

http://codereview.chromium.org/9374013/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/9374013/diff/1/src/objects.cc#newcode7620
src/objects.cc:7620: return
Handle<Object>(GetIsolate()->heap()->undefined_value());
On 2012/02/09 08:01:51, Kevin Millikin wrote:
> You should write this as
> 
> return GetIsolate()->factory()->undefined_value();

Good point. Done.

[Michael Starzinger, 2012-02-09 10:31:15]

LGTM. As discussed offline, all paths through SharedFunctionInfoPrint() are also
covered by a handle scope.