src/runtime.cc - Issue 9374013: Handlify GetSourceCode-related functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 9374013: Handlify GetSourceCode-related functions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Use an easier way to get a handlified undefined. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index d80b4a6945218e15ad17039b851db98822959266..62d3525cbc2f17293ae94abf8f031d59af308b58 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -2001,11 +2001,12 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_FunctionGetScript) {

RUNTIME_FUNCTION(MaybeObject*, Runtime_FunctionGetSourceCode) {

- NoHandleAllocation ha;

+ HandleScope scope(isolate);

ASSERT(args.length() == 1);

- CONVERT_CHECKED(JSFunction, f, args[0]);

- return f->shared()->GetSourceCode();

+ CONVERT_ARG_CHECKED(JSFunction, f, 0);

+ Handle<SharedFunctionInfo> shared(f->shared());

+ return *shared->GetSourceCode();

}

« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »