Issue 9372023: Handle CALLBACKS transitions in NormalizeProperties, CopyInsert and RemoveTransitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9372023: Handle CALLBACKS transitions in NormalizeProperties, CopyInsert and RemoveTransitions. (Closed)

Created:
8 years, 10 months ago by Sven Panne

Modified:
8 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handle CALLBACKS transitions in NormalizeProperties, CopyInsert and RemoveTransitions.

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -14 lines)			Patch
M	src/objects.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	5 chunks	+50 lines, -14 lines	0 comments	Download
M	src/property.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 10 months ago (2012-02-13 09:55:47 UTC) #1

This change spreads the fact that CALLBACKs may contain transitions all over the
place. I think it would make more sense to let CopyFrom() do the
transition-dropping. I wouldn't even rename that function, just add a comment
explaining that it will drop all transitions while copying.

It makes no sense to have a CopyFrom() which does not drop transitions, because
that will destroy the tree-property of our transition tree in almost all cases.

And it also makes a separate GetDescriptorWithoutTransitions() obsolete.

Expand Messages | Collapse Messages