Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 9372012: Revert 121165 - Revert 121068 - linux: add a use_gold flag that defaults to on (Closed)

Created:
8 years, 10 months ago by csilv
Modified:
8 years, 10 months ago
Reviewers:
csilv
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 121165 - Revert 121068 - linux: add a use_gold flag that defaults to on [This CL was backed out speculatively due to failures on the cros trunk bot. But this CL was not the cause of that problem, so I'm un-doing the revert.] Currently, gyp attempts to autodetect whether the linker supports the --icf flag. It's more predictable to just require the caller to specify whether they're using gold. As a first demonstration of this, drop LINKER_USES_ICF code in the Chrome build. (I'll follow up with a gyp patch to remove the LINKER_USES_ICF stuff in gyp.) Review URL: https://chromiumcodereview.appspot.com/9368015 TBR=evan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -19 lines) Patch
M build/common.gypi View 6 chunks +29 lines, -19 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
csilv
8 years, 10 months ago (2012-02-09 03:48:17 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698