Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issue 9368015: Revert 121068 - linux: add a use_gold flag that defaults to on (Closed)

Created:
8 years, 10 months ago by csilv
Modified:
8 years, 10 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 121068 - linux: add a use_gold flag that defaults to on Currently, gyp attempts to autodetect whether the linker supports the --icf flag. It's more predictable to just require the caller to specify whether they're using gold. As a first demonstration of this, drop LINKER_USES_ICF code in the Chrome build. (I'll follow up with a gyp patch to remove the LINKER_USES_ICF stuff in gyp.) Review URL: http://codereview.chromium.org/9316110 TBR=evan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -29 lines) Patch
M build/common.gypi View 6 chunks +19 lines, -29 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
csilv
8 years, 10 months ago (2012-02-09 02:52:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698