Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 9370041: Clean up examples (Closed)

Created:
8 years, 10 months ago by noelallen1
Modified:
8 years, 10 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews
Visibility:
Public.

Description

Clean up examples Simplify hello world examples. Remove DEBUG/RELEASE builds from make. Remove 'helper_functions' from simple hello_world. Move C++ hello_world -> hello_world_interactive. Move Hello_world_c -> hello_world_newlib Copy Hello_world_c -> hello_world_glibc (with glibc TC) This change grately simplifies the hello world cases making it easier to point out exactly what is different between the various builds. It also allows us to stage simple make file changes instead of starting with a more complex one. This change only affect the NaCl SDK builders. BUG=109207 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121374

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1529 lines, -1606 lines) Patch
D native_client_sdk/src/examples/hello_world/Makefile View 1 chunk +0 lines, -183 lines 0 comments Download
D native_client_sdk/src/examples/hello_world/hello_world.cc View 1 chunk +0 lines, -135 lines 0 comments Download
D native_client_sdk/src/examples/hello_world/hello_world.html View 1 chunk +0 lines, -126 lines 0 comments Download
D native_client_sdk/src/examples/hello_world/hello_world.nmf View 1 chunk +0 lines, -6 lines 0 comments Download
D native_client_sdk/src/examples/hello_world/helper_functions.h View 1 chunk +0 lines, -34 lines 0 comments Download
D native_client_sdk/src/examples/hello_world/helper_functions.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D native_client_sdk/src/examples/hello_world/test_helper_functions.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_c/Makefile View 1 chunk +0 lines, -183 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_c/hello_world_c.c View 1 chunk +0 lines, -289 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_c/hello_world_c.html View 1 chunk +0 lines, -126 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_c/hello_world_c.nmf View 1 chunk +0 lines, -6 lines 0 comments Download
M native_client_sdk/src/examples/hello_world_glibc/Makefile View 1 1 chunk +38 lines, -161 lines 0 comments Download
A native_client_sdk/src/examples/hello_world_glibc/hello_world.c View 1 chunk +182 lines, -0 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_glibc/hello_world.cc View 1 chunk +0 lines, -135 lines 0 comments Download
M native_client_sdk/src/examples/hello_world_glibc/hello_world.html View 5 chunks +11 lines, -50 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_glibc/helper_functions.h View 1 chunk +0 lines, -34 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_glibc/helper_functions.cc View 1 chunk +0 lines, -22 lines 0 comments Download
A native_client_sdk/src/examples/hello_world_interactive/Makefile View 1 chunk +70 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world_interactive/hello_world.cc View 1 chunk +135 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world_interactive/hello_world.html View 1 chunk +126 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world_interactive/hello_world.nmf View 1 chunk +6 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world_interactive/helper_functions.h View 1 chunk +34 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world_interactive/helper_functions.cc View 1 chunk +22 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world_interactive/test_helper_functions.cc View 1 chunk +52 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world_newlib/Makefile View 1 1 chunk +61 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world_newlib/hello_world.c View 1 chunk +182 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world_newlib/hello_world.html View 1 chunk +87 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world_newlib/hello_world.nmf View 1 chunk +6 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world_newlib/hello_world_c.c View 1 chunk +289 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world_newlib/hello_world_c.html View 1 chunk +126 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world_newlib/hello_world_c.nmf View 1 chunk +6 lines, -0 lines 0 comments Download
M native_client_sdk/src/examples/index_staging.html View 1 5 chunks +96 lines, -42 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
noelallen1
FYI, the change isn't as bad as it looks. It's really a move of hello_world_c ...
8 years, 10 months ago (2012-02-10 00:27:06 UTC) #1
bradn
lgtm https://chromiumcodereview.appspot.com/9370041/diff/1/native_client_sdk/src/examples/hello_world_glibc/Makefile File native_client_sdk/src/examples/hello_world_glibc/Makefile (right): https://chromiumcodereview.appspot.com/9370041/diff/1/native_client_sdk/src/examples/hello_world_glibc/Makefile#newcode1 native_client_sdk/src/examples/hello_world_glibc/Makefile:1: # Copyright (c) 2011 The Native Client Authors. ...
8 years, 10 months ago (2012-02-10 00:56:16 UTC) #2
noelallen1
8 years, 10 months ago (2012-02-10 22:31:45 UTC) #3
https://chromiumcodereview.appspot.com/9370041/diff/1/native_client_sdk/src/e...
File native_client_sdk/src/examples/hello_world_glibc/Makefile (right):

https://chromiumcodereview.appspot.com/9370041/diff/1/native_client_sdk/src/e...
native_client_sdk/src/examples/hello_world_glibc/Makefile:1: # Copyright (c)
2011 The Native Client Authors. All rights reserved.
On 2012/02/10 00:56:16, bradn wrote:
> 2012

Done.

https://chromiumcodereview.appspot.com/9370041/diff/1/native_client_sdk/src/e...
File native_client_sdk/src/examples/hello_world_newlib/Makefile (right):

https://chromiumcodereview.appspot.com/9370041/diff/1/native_client_sdk/src/e...
native_client_sdk/src/examples/hello_world_newlib/Makefile:1: # Copyright (c)
2011 The Native Client Authors. All rights reserved.
On 2012/02/10 00:56:16, bradn wrote:
> 2012

Done.

Powered by Google App Engine
This is Rietveld 408576698