Remove pthreads patch, roll in new patches, disable unchecked bit readers.

- This updates the git branch to latest SVN w/ cevans and others patches.
- Disabled unchecked bitstream reading per rbultje.
- Removes the static pthreads patch since latest ffmpeg has w32threads.

BUG=none
TEST=ffmpeg_regression_tests

[DaleCurtis, 2012-02-08 23:55:16]

PTAL.

[scherkus (not reviewing), 2012-02-09 00:40:48]

LGTM w/ nits and q's

https://chromiumcodereview.appspot.com/9370003/diff/2001/chromium/scripts/bui...
File chromium/scripts/build_ffmpeg.sh (right):

https://chromiumcodereview.appspot.com/9370003/diff/2001/chromium/scripts/bui...
chromium/scripts/build_ffmpeg.sh:237: add_flag_common --optflags=-O2
this change isn't mentioned in CL description

does this CL also drop the -O2 patch?

https://chromiumcodereview.appspot.com/9370003/diff/2001/chromium/scripts/bui...
chromium/scripts/build_ffmpeg.sh:312: add_flag_common --enable-filter=buffer
did we already do the w32threads switch?

https://chromiumcodereview.appspot.com/9370003/diff/2001/configure
File configure (right):

https://chromiumcodereview.appspot.com/9370003/diff/2001/configure#newcode2155
configure:2155: speed_cflags='-O3'
sanity check: this is reverting back to HEAD version?

[rbultje1, 2012-02-09 00:44:18]

https://chromiumcodereview.appspot.com/9370003/diff/2001/chromium/scripts/bui...
File chromium/scripts/build_ffmpeg.sh (right):

https://chromiumcodereview.appspot.com/9370003/diff/2001/chromium/scripts/bui...
chromium/scripts/build_ffmpeg.sh:312: add_flag_common --enable-filter=buffer
On 2012/02/09 00:40:49, scherkus wrote:
> did we already do the w32threads switch?

That's a new upstream feature, automatically enabled on Win32 target platforms.
Nothing needs to be done in Chrome, except potentially not linking against
pthreads{,-static}.

[DaleCurtis, 2012-02-09 04:37:39]

https://chromiumcodereview.appspot.com/9370003/diff/2001/chromium/scripts/bui...
File chromium/scripts/build_ffmpeg.sh (right):

https://chromiumcodereview.appspot.com/9370003/diff/2001/chromium/scripts/bui...
chromium/scripts/build_ffmpeg.sh:237: add_flag_common --optflags=-O2
On 2012/02/09 00:40:49, scherkus wrote:
> this change isn't mentioned in CL description
> 
> does this CL also drop the -O2 patch?

The static pthreads patch included the -O2 patch, so this is part of rolling out
that patch. Sorry it wasn't clear.

https://chromiumcodereview.appspot.com/9370003/diff/2001/chromium/scripts/bui...
chromium/scripts/build_ffmpeg.sh:312: add_flag_common --enable-filter=buffer
The w32threads switch was automatic, the only diff to the builds I've already
done is in allcodecs.h where there was some static pthreads initialization.

On 2012/02/09 00:44:18, rbultje1 wrote:
> On 2012/02/09 00:40:49, scherkus wrote:
> > did we already do the w32threads switch?
> 
> That's a new upstream feature, automatically enabled on Win32 target
platforms.
> Nothing needs to be done in Chrome, except potentially not linking against
> pthreads{,-static}.

https://chromiumcodereview.appspot.com/9370003/diff/2001/configure
File configure (right):

https://chromiumcodereview.appspot.com/9370003/diff/2001/configure#newcode2155
configure:2155: speed_cflags='-O3'
On 2012/02/09 00:40:49, scherkus wrote:
> sanity check: this is reverting back to HEAD version?

Yes.

[DaleCurtis, 2012-02-09 22:45:32]

Chris, Ronald, any comments or are you okay with Andrew's LGTM?

[Chris Evans, 2012-02-09 23:14:12]

On 2012/02/09 22:45:32, DaleCurtis wrote:
> Chris, Ronald, any comments or are you okay with Andrew's LGTM?

Don't have time to look into this at the moment; I trust Andrew.

[rbultje1, 2012-02-09 23:30:47]

On 2012/02/09 22:45:32, DaleCurtis wrote:
> Chris, Ronald, any comments or are you okay with Andrew's LGTM?

Sorry, forgot explicit LGTM; yes, LGTM for me also.

[DaleCurtis, 2012-02-09 23:33:42]

Thanks guys. Pushed.