Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: configure

Issue 9370003: Remove pthreads patch, roll in new patches, disable unchecked bit readers. (Closed) Base URL: ssh://gerrit.chromium.org:29418/chromium/third_party/ffmpeg.git@master
Patch Set: gyp fix. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: configure
diff --git a/configure b/configure
index d7f2e493c7bd93d842fca9fbf9288b92bcc12566..00f2ebe83a713243b25f5fb11b9a539f1c63dc85 100755
--- a/configure
+++ b/configure
@@ -2152,7 +2152,7 @@ elif $cc -v 2>&1 | grep -qi ^gcc; then
CC_DEPFLAGS='-MMD -MF $(@:.o=.d) -MT $@'
AS_DEPFLAGS='-MMD -MF $(@:.o=.d) -MT $@'
fi
- speed_cflags='-O2'
+ speed_cflags='-O3'
scherkus (not reviewing) 2012/02/09 00:40:49 sanity check: this is reverting back to HEAD versi
DaleCurtis 2012/02/09 04:37:39 Yes.
size_cflags='-Os'
elif $cc --version 2>/dev/null | grep -q Intel; then
cc_type=icc
@@ -2305,7 +2305,6 @@ elif $cc -v 2>&1 | grep -q Open64; then
cc_ident=$($cc -v 2>&1 | head -n1 | tr -d :)
CC_DEPFLAGS='-MMD -MF $(@:.o=.d) -MT $@'
AS_DEPFLAGS='-MMD -MF $(@:.o=.d) -MT $@'
-# O2 produces smaller/faster code on P4 and same performance on Core/Atom.
speed_cflags='-O2'
size_cflags='-Os'
filter_cflags='filter_out -Wdisabled-optimization|-Wtype-limits|-fno-signed-zeros'
@@ -3099,10 +3098,6 @@ if ! disabled pthreads && ! enabled w32threads && ! enabled os2threads; then
add_extralibs -pthreads
elif check_func pthread_create -lpthreadGC2; then
add_extralibs -lpthreadGC2
-# static pthreads improves startup time
- elif check_func pthread_create -lpthreadGC2 -lws2_32; then
- add_cflags -DPTW32_STATIC_LIB
- add_extralibs -lpthreadGC2 -lws2_32
elif ! check_lib pthread.h pthread_create -lpthread; then
disable pthreads
fi
@@ -3385,8 +3380,7 @@ elif enabled ccc; then
elif enabled gcc; then
check_cflags -fno-tree-vectorize
check_cflags -Werror=implicit-function-declaration
-# Removed to allow msys gcc 4.2.1-sjlj to compile
-# check_cflags -Werror=missing-prototypes
+ check_cflags -Werror=missing-prototypes
elif enabled llvm_gcc; then
check_cflags -mllvm -stack-alignment=16
elif enabled clang; then

Powered by Google App Engine
This is Rietveld 408576698