Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 9369051: Force close of browser Windows when complete. (Closed)

Created:
8 years, 10 months ago by Emily Fortuna
Modified:
8 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Force close of browser Windows when complete. Committed: https://code.google.com/p/dart/source/detail?r=4241

Patch Set 1 : '' #

Patch Set 2 : '' #

Total comments: 8

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -8 lines) Patch
M tools/testing/dart/test_runner.dart View 1 2 9 chunks +67 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Emily Fortuna
Please do look carefully at how I'm doing this. I'm not thrilled with how I ...
8 years, 10 months ago (2012-02-14 00:19:55 UTC) #1
Jennifer Messerly
https://chromiumcodereview.appspot.com/9369051/diff/9001/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://chromiumcodereview.appspot.com/9369051/diff/9001/tools/testing/dart/test_runner.dart#newcode544 tools/testing/dart/test_runner.dart:544: testSuite.notifyIfBrowserCleanupNeeded(this); an alternate idea: instead of changing test_suite, could ...
8 years, 10 months ago (2012-02-14 02:17:25 UTC) #2
Bill Hesse
I like the approach in the first patch set better, and I have an idea ...
8 years, 10 months ago (2012-02-14 12:46:00 UTC) #3
Bill Hesse
I wasn't done: with handlers: errorHandler: decrement activeCleanupCount, if zero then allDone() exitHandler: decrement activeCleanupCount, ...
8 years, 10 months ago (2012-02-14 12:49:53 UTC) #4
Emily Fortuna
Hello all, Please take another look. Bill, I initially wrote this in the more general ...
8 years, 10 months ago (2012-02-14 23:55:44 UTC) #5
Jennifer Messerly
8 years, 10 months ago (2012-02-15 00:51:59 UTC) #6
lgtm.

Let's get this checked in to make the build bots hopefully more stable. But feel
free to refactor & generalize after.

Powered by Google App Engine
This is Rietveld 408576698