Force close of browser Windows when complete.

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 182 matching lines @@
   String directoryPath;
   List<String> statusFilePaths;
   Function doTest;
   Function doDone;
   int activeTestGenerators = 0;
   bool listingDone = false;
   TestExpectations testExpectations;
   List<TestInformation> cachedTests;
   final String dartDir;
   Function globalTemporaryDirectory;
+  /** 
+   * Reference to our test queue, so that we can notify the queue if it needs
+   * to run any cleanup after the suite completes.
+   */
+  ProcessQueue _allDoneCallbackListener;
 
   StandardTestSuite(Map this.configuration,
                     String this.suiteName,
                     String this.directoryPath,
                     List<String> this.statusFilePaths)
     : dartDir = TestUtils.dartDir();
 
   /**
    * The default implementation assumes a file is a test if
    * it ends in "Test.dart".
@@ skipping 344 matching lines @@
       var testCase = new BrowserTestCase(
           testName,
           compilerExecutable,
           compilerArgs,
           'python',
           args,
           configuration,
           completeHandler,
           expectations,
           optionsFromFile['isNegative']);
+      if ((_allDoneCallbackListener != null)) {

[Jennifer Messerly, 2012/02/14 02:17:25]

extra parens

[Emily Fortuna, 2012/02/14 23:55:44]

Done.

+        _allDoneCallbackListener.browserUsed = configuration['browser'];
+      }
       doTest(testCase);
     }
   }
 
+  /** 
+   * Notify the process queue that once all the tests have completed, we need
+   * to run a process to clean up any bad state that WebDriver may have left
+   * (extra browser processes, etc).
+   */
+  void notifyIfBrowserCleanupNeeded(ProcessQueue queue) {
+    _allDoneCallbackListener = queue;
+  }
+  
   bool get requiresCleanTemporaryDirectory() =>
       configuration['component'] == 'dartc' ||
       configuration['component'] == 'chromium';
 
   /**
    * Create a directory for the generated test.  If a Dart language test
    * needs to be run in a browser, the Dart test needs to be embedded in
    * an HTML page, with a testing framework based on scripting and DOM events.
    * These scripts and pages are written to a generated_test directory,
    * usually inside the build directory of the checkout.
@@ skipping 543 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
 """;
     print(report);
    }
 }