Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 9365007: Don't use system libpng by default. It causes security maintenance problems (Closed)

Created:
8 years, 10 months ago by Chris Evans
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Don't use system libpng by default. It causes security maintenance problems for ChromeOS. It's worth noting that we also don't use the system library for many other important components such as libxml. BUG=112822 R=wad,abarth Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121199

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/libpng/libpng.gyp View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Chris Evans
Will, in terms of impact, I think ChromeOS should "own" this CL.
8 years, 10 months ago (2012-02-08 03:28:29 UTC) #1
Will Drewry
LGTM I think the binary size to maintainability tradeoff makes sense -- especially in the ...
8 years, 10 months ago (2012-02-08 03:31:00 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 10 months ago (2012-02-08 05:19:31 UTC) #3
Tom Sepez
Rubberstamp LGTM.
8 years, 10 months ago (2012-02-08 05:26:04 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 10 months ago (2012-02-08 05:32:23 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 10 months ago (2012-02-08 05:43:14 UTC) #6
abarth-chromium
I attempt to LGTM it
8 years, 10 months ago (2012-02-08 05:49:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/9365007/2001
8 years, 10 months ago (2012-02-08 05:50:31 UTC) #8
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 10 months ago (2012-02-08 06:56:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/9365007/2001
8 years, 10 months ago (2012-02-08 19:39:21 UTC) #10
commit-bot: I haz the power
Change committed as 121044
8 years, 10 months ago (2012-02-08 21:43:53 UTC) #11
kevenmaster857
6 years, 7 months ago (2014-05-01 09:56:36 UTC) #12
kevenmaster857
6 years, 7 months ago (2014-05-01 09:56:38 UTC) #13
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698