third_party/libpng/libpng.gyp - Issue 9365007: Don't use system libpng by default. It causes security maintenance problems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libpng/libpng.gyp

Issue 9365007: Don't use system libpng by default. It causes security maintenance problems (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/libpng/libpng.gyp

===================================================================

--- third_party/libpng/libpng.gyp (revision 120786)

+++ third_party/libpng/libpng.gyp (working copy)

@@ -6,8 +6,9 @@

'variables': {

'conditions': [

[ 'os_posix == 1 and OS != "mac" and OS != "android"', {

- # Link to system .so since we already use it due to GTK.

- 'use_system_libpng%': 1,

+ # Maybe link to system .so once the security concerns are thought

+ # through, since we already use it due to GTK.

+ 'use_system_libpng%': 0,

}, { # os_posix != 1 or OS == "mac"

'use_system_libpng%': 0,

}],

« no previous file with comments | « no previous file | no next file » | no next file with comments »