Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 9361046: Revert 121031 - Eliminate DownloadProgressUpdated. (Closed)

Created:
8 years, 10 months ago by Avi (use Gerrit)
Modified:
8 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Revert 121031 - Eliminate DownloadProgressUpdated. content::DownloadManagerDelegate::DownloadProgressUpdated was called out of sync with the content::DownloadItem::Observer calls. Eliminate it, as the notification that it provides is anti-useful. BUG=112841 TEST=as in bug Review URL: https://chromiumcodereview.appspot.com/9363001 TBR=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M chrome/browser/download/chrome_download_manager_delegate.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/download/download_status_updater.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/download/download_status_updater.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M content/browser/download/download_manager_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 5 chunks +8 lines, -0 lines 0 comments Download
M content/public/browser/download_manager_delegate.h View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Avi (use Gerrit)
8 years, 10 months ago (2012-02-08 20:59:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698