Issue 9361046: Revert 121031 - Eliminate DownloadProgressUpdated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9361046: Revert 121031 - Eliminate DownloadProgressUpdated. (Closed)

Created:
8 years, 10 months ago by Avi (use Gerrit)

Modified:
8 years, 10 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, rdsmith+dwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 121031 - Eliminate DownloadProgressUpdated. content::DownloadManagerDelegate::DownloadProgressUpdated was called out of sync with the content::DownloadItem::Observer calls. Eliminate it, as the notification that it provides is anti-useful. BUG=112841 TEST=as in bug Review URL: https://chromiumcodereview.appspot.com/9363001 TBR=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121041

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -18 lines)			Patch
M	chrome/browser/download/chrome_download_manager_delegate.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/download/chrome_download_manager_delegate.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/download/download_status_updater.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/download/download_status_updater.cc	View	3 chunks	+0 lines, -13 lines	0 comments	Download
M	content/browser/download/download_manager_impl.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/download/download_manager_impl.cc	View	5 chunks	+8 lines, -0 lines	0 comments	Download
M	content/public/browser/download_manager_delegate.h	View	2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)