Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 9358057: Merge 107094 - Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tes… (Closed)

Created:
8 years, 10 months ago by Nico
Modified:
8 years, 10 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Merge 107094 - Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests. https://bugs.webkit.org/show_bug.cgi?id=78007 This got broken by: http://trac.webkit.org/changeset/105470 And the tests were accidentally(?) disabled in: http://trac.webkit.org/changeset/95191 There is still three tests that fail from the set, but the cause for these is different, which I'm still investigating. Patch by Alexei Svitkine <asvitkine@chromium.org>; on 2012-02-08 Reviewed by James Robinson. Source/WebKit/chromium: * src/NonCompositedContentHost.cpp: (WebKit::NonCompositedContentHost::NonCompositedContentHost): LayoutTests: * platform/chromium/test_expectations.txt: TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=107711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2748 lines, -119 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +2008 lines, -5 lines 0 comments Download
M LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-n-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-w-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/overhang-e-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/overhang-n-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/overhang-ne-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/overhang-nw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/overhang-s-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/overhang-se-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/overhang-sw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/rubberbanding/overhang-w-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/test_expectations.txt View 42 chunks +149 lines, -110 lines 0 comments Download
M Source/WebKit/chromium/ChangeLog View 1 chunk +585 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/NonCompositedContentHost.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
8 years, 10 months ago (2012-02-14 15:41:49 UTC) #1
Nico
8 years, 10 months ago (2012-02-14 15:42:31 UTC) #2
There you go :-)

Powered by Google App Engine
This is Rietveld 408576698