Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2535)

Unified Diff: dart/frog/leg/ssa/codegen.dart

Issue 9355031: Improve List implementation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased and resolved conflicts Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/ssa/builder.dart ('k') | dart/frog/leg/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/ssa/codegen.dart
diff --git a/dart/frog/leg/ssa/codegen.dart b/dart/frog/leg/ssa/codegen.dart
index a935973b623a91acdc1efcd9433ae78d0ec7b17a..c2dc0179fab0aa4739a49a259691b6fa00242ece 100644
--- a/dart/frog/leg/ssa/codegen.dart
+++ b/dart/frog/leg/ssa/codegen.dart
@@ -694,7 +694,8 @@ class SsaCodeGenerator implements HVisitor {
use(node.index, JSPrecedence.RELATIONAL_PRECEDENCE);
buffer.add(' >= ');
use(node.length, JSPrecedence.SHIFT_PRECEDENCE);
- buffer.add(") throw 'Out of bounds'");
+ buffer.add(") ");
+ generateFail('ioore', node.index);
}
visitIntegerCheck(HIntegerCheck node) {
@@ -702,7 +703,20 @@ class SsaCodeGenerator implements HVisitor {
use(node.value, JSPrecedence.EQUALITY_PRECEDENCE);
buffer.add(' !== (');
use(node.value, JSPrecedence.BITWISE_OR_PRECEDENCE);
- buffer.add(" | 0)) throw 'Illegal argument'");
+ buffer.add(" | 0)) ");
+ generateFail('iae', node.value);
+ }
+
+ void generateFail(String helperName, HInstruction argument) {
+ Element helper = compiler.findHelper(new SourceString(helperName));
+ compiler.registerStaticUse(helper);
+ buffer.add('throw ');
+ beginExpression(JSPrecedence.EXPRESSION_PRECEDENCE);
+ beginExpression(JSPrecedence.CALL_PRECEDENCE);
+ buffer.add(compiler.namer.isolateAccess(helper));
+ visitArguments([null, argument]);
+ endExpression(JSPrecedence.CALL_PRECEDENCE);
+ endExpression(JSPrecedence.EXPRESSION_PRECEDENCE);
}
void addIndentation() {
« no previous file with comments | « dart/frog/leg/ssa/builder.dart ('k') | dart/frog/leg/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698