Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: dart/frog/leg/ssa/builder.dart

Issue 9355031: Improve List implementation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased and resolved conflicts Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/scanner/scanner.dart ('k') | dart/frog/leg/ssa/codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/ssa/builder.dart
diff --git a/dart/frog/leg/ssa/builder.dart b/dart/frog/leg/ssa/builder.dart
index 1e3ab87df0817da8773959a82a5c8b0234e08baf..5847a4cbc6ac077a59fe4657c71eca1daa37fc8c 100644
--- a/dart/frog/leg/ssa/builder.dart
+++ b/dart/frog/leg/ssa/builder.dart
@@ -55,6 +55,12 @@ class Interceptors {
return result;
}
+ Element getStaticSetInterceptor(SourceString name) {
+ String mangledName = "builtin\$set\$${name}";
+ Element result = compiler.findHelper(new SourceString(mangledName));
+ return result;
+ }
+
Element getOperatorInterceptor(Operator op) {
SourceString name = mapOperatorToMethodName(op);
Element result = compiler.findHelper(name);
@@ -1291,8 +1297,20 @@ class SsaBuilder implements Visitor {
visit(send.receiver);
receiver = pop();
}
- add(new HInvokeDynamicSetter(
- selector, null, dartSetterName, receiver, value));
+ Element staticInterceptor = null;
+ if (methodInterceptionEnabled) {
+ staticInterceptor =
+ interceptors.getStaticSetInterceptor(dartSetterName);
+ }
+ if (staticInterceptor != null) {
+ HStatic target = new HStatic(staticInterceptor);
+ add(target);
+ List<HInstruction> inputs = <HInstruction>[target, receiver, value];
+ add(new HInvokeInterceptor(selector, dartSetterName, false, inputs));
+ } else {
+ add(new HInvokeDynamicSetter(selector, null, dartSetterName,
+ receiver, value));
+ }
stack.add(value);
} else {
localsHandler.updateLocal(element, value);
« no previous file with comments | « dart/frog/leg/scanner/scanner.dart ('k') | dart/frog/leg/ssa/codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698