Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9353002: Created new PanelStrip base class and make DockedPanelStrip and OverflowPanelStrip its subclasses. (Closed)

Created:
8 years, 10 months ago by jennb
Modified:
8 years, 10 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, jennb, jianli, dcheng, prasadt
Visibility:
Public.

Description

Created new PanelStrip base class and make DockedPanelStrip and OverflowPanelStrip its subclasses. Part of refactor to allow for a DetachedPanelStrip. Refactor of Panel to know it's current panel strip will be a separate patch. BUG=None TEST=No new tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120809

Patch Set 1 #

Patch Set 2 : added the new files - d'oh! #

Total comments: 8

Patch Set 3 : review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -82 lines) Patch
M chrome/browser/ui/panels/docked_panel_strip.h View 1 2 4 chunks +22 lines, -20 lines 0 comments Download
M chrome/browser/ui/panels/docked_panel_strip.cc View 1 2 10 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/ui/panels/overflow_panel_strip.h View 1 2 3 chunks +13 lines, -17 lines 0 comments Download
M chrome/browser/ui/panels/overflow_panel_strip.cc View 1 2 7 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_manager.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_manager.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/panels/panel_overflow_browsertest.cc View 14 chunks +14 lines, -14 lines 0 comments Download
A chrome/browser/ui/panels/panel_strip.h View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
A chrome/browser/ui/panels/panel_strip.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jennb
dimich - Basic refactor so your mac overflow patch can use the new panel strip ...
8 years, 10 months ago (2012-02-07 00:27:27 UTC) #1
Dmitry Titov
https://chromiumcodereview.appspot.com/9353002/diff/20/chrome/browser/ui/panels/panel_strip.h File chrome/browser/ui/panels/panel_strip.h (right): https://chromiumcodereview.appspot.com/9353002/diff/20/chrome/browser/ui/panels/panel_strip.h#newcode48 chrome/browser/ui/panels/panel_strip.h:48: const gfx::Size& preferred_window_size) = 0; Could you add a ...
8 years, 10 months ago (2012-02-07 00:46:46 UTC) #2
jennb
https://chromiumcodereview.appspot.com/9353002/diff/20/chrome/browser/ui/panels/panel_strip.h File chrome/browser/ui/panels/panel_strip.h (right): https://chromiumcodereview.appspot.com/9353002/diff/20/chrome/browser/ui/panels/panel_strip.h#newcode48 chrome/browser/ui/panels/panel_strip.h:48: const gfx::Size& preferred_window_size) = 0; On 2012/02/07 00:46:46, Dmitry ...
8 years, 10 months ago (2012-02-07 01:06:09 UTC) #3
Dmitry Titov
LGTM
8 years, 10 months ago (2012-02-07 02:09:01 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 18:53:34 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698