Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: chrome/browser/ui/panels/panel_manager.cc

Issue 9353002: Created new PanelStrip base class and make DockedPanelStrip and OverflowPanelStrip its subclasses. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review feedback Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel_manager.h ('k') | chrome/browser/ui/panels/panel_overflow_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_manager.cc
diff --git a/chrome/browser/ui/panels/panel_manager.cc b/chrome/browser/ui/panels/panel_manager.cc
index a7fce20ce08b4ea4836d6e9560a43480867913ab..921ea7ebf2a408aae67fc16f33936f3bebec4d20 100644
--- a/chrome/browser/ui/panels/panel_manager.cc
+++ b/chrome/browser/ui/panels/panel_manager.cc
@@ -153,9 +153,9 @@ void PanelManager::Remove(Panel* panel) {
full_screen_mode_timer_.Stop();
#endif
- if (docked_strip_->Remove(panel))
+ if (docked_strip_->RemovePanel(panel))
return;
- bool removed = overflow_strip_->Remove(panel);
+ bool removed = overflow_strip_->RemovePanel(panel);
DCHECK(removed);
}
@@ -194,7 +194,7 @@ void PanelManager::OnPreferredWindowSizeChanged(
Panel* panel, const gfx::Size& preferred_window_size) {
if (!auto_sizing_enabled_)
return;
- docked_strip_->OnWindowSizeChanged(panel, preferred_window_size);
+ docked_strip_->ResizePanelWindow(panel, preferred_window_size);
}
void PanelManager::ResizePanel(Panel* panel, const gfx::Size& new_size) {
@@ -204,7 +204,7 @@ void PanelManager::ResizePanel(Panel* panel, const gfx::Size& new_size) {
LOG(INFO) << "Resizing auto-resizable Panels is not supported yet.";
return;
}
- docked_strip_->OnWindowSizeChanged(panel, new_size);
+ docked_strip_->ResizePanelWindow(panel, new_size);
}
bool PanelManager::ShouldBringUpTitlebars(int mouse_x, int mouse_y) const {
@@ -257,9 +257,9 @@ void PanelManager::OnAutoHidingDesktopBarVisibilityChanged(
docked_strip_->OnAutoHidingDesktopBarVisibilityChanged(alignment, visibility);
}
-void PanelManager::RemoveAll() {
- docked_strip_->RemoveAll();
- overflow_strip_->RemoveAll();
+void PanelManager::CloseAll() {
+ docked_strip_->CloseAll();
+ overflow_strip_->CloseAll();
}
int PanelManager::num_panels() const {
« no previous file with comments | « chrome/browser/ui/panels/panel_manager.h ('k') | chrome/browser/ui/panels/panel_overflow_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698