Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4062)

Unified Diff: chrome/browser/web_applications/web_app.h

Issue 9346013: Publish app shortcuts on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comments Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_applications/web_app.h
diff --git a/chrome/browser/web_applications/web_app.h b/chrome/browser/web_applications/web_app.h
index 16175fc0f43a8460798b961be16526661a2bee2c..542f5dbecc8353ac0bad5bfacc424b839a8bad0b 100644
--- a/chrome/browser/web_applications/web_app.h
+++ b/chrome/browser/web_applications/web_app.h
@@ -67,13 +67,21 @@ std::string GetWMClassFromAppName(std::string app_name);
namespace internals {
#if defined(OS_WIN)
-FilePath GetSanitizedFileName(const string16& name);
-
bool CheckAndSaveIcon(const FilePath& icon_file, const SkBitmap& image);
#endif
FilePath GetWebAppDataDirectory(const FilePath& root_dir,
const ShellIntegration::ShortcutInfo& info);
+
+// Does the actual job of creating a shortcut (see CreateShortcut above).
jeremy 2012/02/08 09:10:45 nit: "CreateShortcut()"
---DO-NOT-USE---rsesek1 2012/02/08 12:24:33 Does this have to only be called on the FILE threa
sail 2012/02/08 19:09:15 Done.
sail 2012/02/08 19:09:15 Yea. Ahh I forgot to add the DCHECK() on the Mac v
sail 2012/02/08 19:09:15 Yea. Ahh I forgot to add the DCHECK() on the Mac v
+// This must be called on the file thread.
+void CreateShortcutTask(const FilePath& web_app_path,
+ const FilePath& profile_path,
+ const ShellIntegration::ShortcutInfo& shortcut_info);
+
+// Returns sanitized name that could be used as a file name
jeremy 2012/02/08 09:10:45 How about: Sanitizes |name| and returns a version
sail 2012/02/08 19:09:15 Done.
+FilePath GetSanitizedFileName(const string16& name);
+
} // namespace internals
} // namespace web_app

Powered by Google App Engine
This is Rietveld 408576698