Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: chrome/browser/web_applications/web_app.h

Issue 9346013: Publish app shortcuts on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comments Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_H_ 5 #ifndef CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_H_
6 #define CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_H_ 6 #define CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 #if defined(TOOLKIT_USES_GTK) 60 #if defined(TOOLKIT_USES_GTK)
61 // GTK+ windows that correspond to web apps need to have a deterministic (and 61 // GTK+ windows that correspond to web apps need to have a deterministic (and
62 // different) WMClass than normal chrome windows so the window manager groups 62 // different) WMClass than normal chrome windows so the window manager groups
63 // them as a separate application. 63 // them as a separate application.
64 std::string GetWMClassFromAppName(std::string app_name); 64 std::string GetWMClassFromAppName(std::string app_name);
65 #endif 65 #endif
66 66
67 namespace internals { 67 namespace internals {
68 68
69 #if defined(OS_WIN) 69 #if defined(OS_WIN)
70 FilePath GetSanitizedFileName(const string16& name);
71
72 bool CheckAndSaveIcon(const FilePath& icon_file, const SkBitmap& image); 70 bool CheckAndSaveIcon(const FilePath& icon_file, const SkBitmap& image);
73 #endif 71 #endif
74 72
75 FilePath GetWebAppDataDirectory(const FilePath& root_dir, 73 FilePath GetWebAppDataDirectory(const FilePath& root_dir,
76 const ShellIntegration::ShortcutInfo& info); 74 const ShellIntegration::ShortcutInfo& info);
75
76 // Does the actual job of creating a shortcut (see CreateShortcut above).
jeremy 2012/02/08 09:10:45 nit: "CreateShortcut()"
---DO-NOT-USE---rsesek1 2012/02/08 12:24:33 Does this have to only be called on the FILE threa
sail 2012/02/08 19:09:15 Done.
sail 2012/02/08 19:09:15 Yea. Ahh I forgot to add the DCHECK() on the Mac v
sail 2012/02/08 19:09:15 Yea. Ahh I forgot to add the DCHECK() on the Mac v
77 // This must be called on the file thread.
78 void CreateShortcutTask(const FilePath& web_app_path,
79 const FilePath& profile_path,
80 const ShellIntegration::ShortcutInfo& shortcut_info);
81
82 // Returns sanitized name that could be used as a file name
jeremy 2012/02/08 09:10:45 How about: Sanitizes |name| and returns a version
sail 2012/02/08 19:09:15 Done.
83 FilePath GetSanitizedFileName(const string16& name);
84
77 } // namespace internals 85 } // namespace internals
78 86
79 } // namespace web_app 87 } // namespace web_app
80 88
81 #endif // CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_H_ 89 #endif // CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698