Chromium Code Reviews
Help | Chromium Project | Sign in
(229)

Issue 9323025: Fix races in CFTxtFieldUndo and CFTxtFieldRedo tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by grt (no reviews 7.31-8.19)
Modified:
3 years, 6 months ago
Reviewers:
robertshield
CC:
chromium-reviews, amit, robertshield
Visibility:
Public.

Description

Fix races in CFTxtFieldUndo and CFTxtFieldRedo tests. These tests were counting on a guarantee that value change events would come in before menu popup events. As it happens, this isn't always the case. The tests now wait for the inital value change event to come in before performing subsequent operations, thereby avoiding the race. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M chrome_frame/test/ui_test.cc View 2 chunks +21 lines, -14 lines 0 comments Download
Commit: (user is not authenticated) CQ not working?

Messages

Total messages: 2 (0 generated)
grt (no reviews 7.31-8.19)
3 years, 6 months ago (2012-02-03 04:58:23 UTC) #1
robertshield
3 years, 6 months ago (2012-02-03 13:22:43 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3ea459f