Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 9323025: Fix races in CFTxtFieldUndo and CFTxtFieldRedo tests. (Closed)

Created:
5 years, 9 months ago by grt (UTC plus 2)
Modified:
5 years, 9 months ago
Reviewers:
robertshield
CC:
chromium-reviews, amit, robertshield
Visibility:
Public.

Description

Fix races in CFTxtFieldUndo and CFTxtFieldRedo tests. These tests were counting on a guarantee that value change events would come in before menu popup events. As it happens, this isn't always the case. The tests now wait for the inital value change event to come in before performing subsequent operations, thereby avoiding the race. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M chrome_frame/test/ui_test.cc View 2 chunks +21 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
grt (UTC plus 2)
5 years, 9 months ago (2012-02-03 04:58:23 UTC) #1
robertshield
5 years, 9 months ago (2012-02-03 13:22:43 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld efc10ee0f