Re-added OnChannelClosing in MediaStreamDispatcherHost to close open media devices.

Re-added OnChannelClosing in MediaStreamDispatcherHost to close open media devices.

BUG=111340
TEST=content_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123207

[mflodman_chromium_OOO, 2012-02-03 13:48:15]

Wei,
I re-added MediaStreamDispatcherHost::OnChannelClosing to close open devices. I
had to make Controller::handlers a map to be able to remove the handler if
MediaStreamDispatcherHost::OnChannelClosing is triggered before
VideoCaptureHost::OnChannelClosing or if a device has been opened and no
started.

I'll add a unit test on Monday to Create, Start, Close and verify devices_ adn
controllers_ are both empty.

Comments or thoughts?

[mflodman_chromium_OOO, 2012-02-06 19:02:14]

Added test case to unittest.

[wjia(left Chromium), 2012-02-09 05:53:47]

as discussed offline, please double check if code change in VCM is needed.

[mflodman_chromium_OOO, 2012-02-10 13:24:40]

http://codereview.chromium.org/9320070/diff/6001/content/browser/renderer_hos...
File content/browser/renderer_host/media/video_capture_manager.cc (right):

http://codereview.chromium.org/9320070/diff/6001/content/browser/renderer_hos...
content/browser/renderer_host/media/video_capture_manager.cc:55:
vc_device_thread_.message_loop()->PostTask(
There is a case when |controllers_| won't be empty here. I'll make a follow up
CL for that as soon as this CL committed, rather than making that fix here.

[mflodman_chromium_OOO, 2012-02-14 16:15:48]

Changed VideoCaptureManager destructor based on
http://codereview.chromium.org/9389006/

[wjia(left Chromium), 2012-02-15 01:39:01]

lgtm with nit: copyright years.

[mflodman_chromium_OOO, 2012-02-15 13:12:58]

On 2012/02/15 01:39:01, wjia wrote:
> lgtm with nit: copyright years.

Done.

[tommi (sloooow) - chröme, 2012-02-23 10:03:22]

couple of nits (better late than never, right?)

https://chromiumcodereview.appspot.com/9320070/diff/17001/content/browser/ren...
File content/browser/renderer_host/media/media_stream_dispatcher_host.cc
(right):

https://chromiumcodereview.appspot.com/9320070/diff/17001/content/browser/ren...
content/browser/renderer_host/media/media_stream_dispatcher_host.cc:66:
std::string label = it->first;
no need to create an extra string copy. should just be:
manager()->StopGeneratedStream(it->first);

https://chromiumcodereview.appspot.com/9320070/diff/17001/content/browser/ren...
File content/browser/renderer_host/media/video_capture_manager_unittest.cc
(right):

https://chromiumcodereview.appspot.com/9320070/diff/17001/content/browser/ren...
content/browser/renderer_host/media/video_capture_manager_unittest.cc:287:
.Times(1);
indent is off here and below.  should be
EXPECT_CALL(...)
    .Times(1);