Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9320038: Move test.dart's check for missing test directories from co19 to general framework. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment, add error if status file not found. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index b6eb454ae9a4976d39a81e46fde0a0263f1c0e84..324099027e2a5b15ee8705c2633501895da5b38f 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -227,9 +227,17 @@ class StandardTestSuite implements TestSuite {
dir.errorHandler = (s) {
throw s;
};
- dir.fileHandler = processFile;
- dir.doneHandler = directoryListingDone;
- dir.list(recursive: listRecursively());
+ dir.existsHandler = (bool exists) {
+ if (!exists) {
+ print('Directory containing tests not found: $directoryPath');
+ directoryListingDone(false);
+ } else {
+ dir.fileHandler = processFile;
+ dir.doneHandler = directoryListingDone;
+ dir.list(recursive: listRecursively());
+ }
+ };
+ dir.exists();
}
void enqueueTestCaseFromTestInformation(TestInformation info) {
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698