tools/testing/dart/status_file_parser.dart - Issue 9320038: Move test.dart's check for missing test directories from co19 to general framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/status_file_parser.dart

Issue 9320038: Move test.dart's check for missing test directories from co19 to general framework. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment, add error if status file not found. Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/status_file_parser.dart

diff --git a/tools/testing/dart/status_file_parser.dart b/tools/testing/dart/status_file_parser.dart

index 3721df86442caca6cc585a072752cdc18044cd7a..6e60b7888d333fd4fa0b36556adde3bb2926d5bf 100644

--- a/tools/testing/dart/status_file_parser.dart

+++ b/tools/testing/dart/status_file_parser.dart

@@ -56,7 +56,9 @@ void ReadTestExpectationsInto(TestExpectations expectations,

void ReadConfigurationInto(path, sections, onDone) {

File file = new File(path);

- if (!file.existsSync()) return; // TODO(whesse): Handle missing file.

+ if (!file.existsSync()) {

+ throw new Exception('Cannot find test status file $path');

+ }

InputStream file_stream = file.openInputStream();

StringInputStream lines = new StringInputStream(file_stream);

« no previous file with comments | « tests/co19/test_config.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »