Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9320037: Support passing DartVM flags via DART_FLAGS. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/drt-trampoline.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index b6eb454ae9a4976d39a81e46fde0a0263f1c0e84..3f28abaa7b3348688290547fcd3a8a81febb8963 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -477,20 +477,16 @@ class StandardTestSuite implements TestSuite {
Expect.fail('unimplemented component $component');
}
- String executable = dumpRenderTreeFilename;
List<String> args;
if (component == 'webdriver') {
- executable = 'python';
- if (new Platform().operatingSystem() == 'windows') {
- // For Windows, the first command, must have the Windows
- // slash direction.
- // TODO(efortuna): Get rid of this hack when issue 1306 is fixed.
- executable = executable.replaceAll('/', '\\');
- }
args = ['$dartDir/tools/testing/run_selenium.py', '--out=$htmlPath',
'--browser=${configuration["browser"]}'];
} else {
- args = ['--no-timeout'];
+ args = [
+ '$dartDir/tools/testing/drt-trampoline.py',
+ dumpRenderTreeFilename,
+ '--no-timeout'
+ ];
if (component == 'dartium') {
var dartFlags = ['--ignore-unrecognized-flags'];
if (configuration["checked"]) {
@@ -507,7 +503,7 @@ class StandardTestSuite implements TestSuite {
testName,
compilerExecutable,
compilerArgs,
- executable,
+ 'python',
args,
configuration,
completeHandler,
« no previous file with comments | « no previous file | tools/testing/drt-trampoline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698