Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 9320037: Support passing DartVM flags via DART_FLAGS. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tools/testing/drt-trampoline.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library("test_suite"); 5 #library("test_suite");
6 6
7 #import("dart:io"); 7 #import("dart:io");
8 #import("status_file_parser.dart"); 8 #import("status_file_parser.dart");
9 #import("test_runner.dart"); 9 #import("test_runner.dart");
10 #import("multitest.dart"); 10 #import("multitest.dart");
(...skipping 459 matching lines...) Expand 10 before | Expand all | Expand 10 after
470 break; 470 break;
471 case 'dartium': 471 case 'dartium':
472 // No compilation phase. 472 // No compilation phase.
473 compilerExecutable = null; 473 compilerExecutable = null;
474 compilerArgs = null; 474 compilerArgs = null;
475 break; 475 break;
476 default: 476 default:
477 Expect.fail('unimplemented component $component'); 477 Expect.fail('unimplemented component $component');
478 } 478 }
479 479
480 String executable = dumpRenderTreeFilename;
481 List<String> args; 480 List<String> args;
482 if (component == 'webdriver') { 481 if (component == 'webdriver') {
483 executable = 'python';
484 if (new Platform().operatingSystem() == 'windows') {
485 // For Windows, the first command, must have the Windows
486 // slash direction.
487 // TODO(efortuna): Get rid of this hack when issue 1306 is fixed.
488 executable = executable.replaceAll('/', '\\');
489 }
490 args = ['$dartDir/tools/testing/run_selenium.py', '--out=$htmlPath', 482 args = ['$dartDir/tools/testing/run_selenium.py', '--out=$htmlPath',
491 '--browser=${configuration["browser"]}']; 483 '--browser=${configuration["browser"]}'];
492 } else { 484 } else {
493 args = ['--no-timeout']; 485 args = [
486 '$dartDir/tools/testing/drt-trampoline.py',
487 dumpRenderTreeFilename,
488 '--no-timeout'
489 ];
494 if (component == 'dartium') { 490 if (component == 'dartium') {
495 var dartFlags = ['--ignore-unrecognized-flags']; 491 var dartFlags = ['--ignore-unrecognized-flags'];
496 if (configuration["checked"]) { 492 if (configuration["checked"]) {
497 dartFlags.add('--enable_asserts'); 493 dartFlags.add('--enable_asserts');
498 dartFlags.add("--enable_type_checks"); 494 dartFlags.add("--enable_type_checks");
499 } 495 }
500 dartFlags.addAll(vmOptions); 496 dartFlags.addAll(vmOptions);
501 args.add('--dart-flags=${Strings.join(dartFlags, " ")}'); 497 args.add('--dart-flags=${Strings.join(dartFlags, " ")}');
502 } 498 }
503 args.add(htmlPath); 499 args.add(htmlPath);
504 } 500 }
505 // Create BrowserTestCase and queue it. 501 // Create BrowserTestCase and queue it.
506 var testCase = new BrowserTestCase( 502 var testCase = new BrowserTestCase(
507 testName, 503 testName,
508 compilerExecutable, 504 compilerExecutable,
509 compilerArgs, 505 compilerArgs,
510 executable, 506 'python',
511 args, 507 args,
512 configuration, 508 configuration,
513 completeHandler, 509 completeHandler,
514 expectations, 510 expectations,
515 optionsFromFile['isNegative']); 511 optionsFromFile['isNegative']);
516 doTest(testCase); 512 doTest(testCase);
517 } 513 }
518 } 514 }
519 515
520 bool get requiresCleanTemporaryDirectory() => 516 bool get requiresCleanTemporaryDirectory() =>
(...skipping 545 matching lines...) Expand 10 before | Expand all | Expand 10 after
1066 * $noCrash tests are expected to be flaky but not crash 1062 * $noCrash tests are expected to be flaky but not crash
1067 * $pass tests are expected to pass 1063 * $pass tests are expected to pass
1068 * $failOk tests are expected to fail that we won't fix 1064 * $failOk tests are expected to fail that we won't fix
1069 * $fail tests are expected to fail that we should fix 1065 * $fail tests are expected to fail that we should fix
1070 * $crash tests are expected to crash that we should fix 1066 * $crash tests are expected to crash that we should fix
1071 * $timeout tests are allowed to timeout 1067 * $timeout tests are allowed to timeout
1072 """; 1068 """;
1073 print(report); 1069 print(report);
1074 } 1070 }
1075 } 1071 }
OLDNEW
« no previous file with comments | « no previous file | tools/testing/drt-trampoline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698