Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 9318019: [uber page] Improve URL mapping for extension URLS. (Closed)

Created:
8 years, 10 months ago by csilv
Modified:
8 years, 10 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Visibility:
Public.

Description

[uber page] Improve URL mapping for extension URLS. BUG=111900 TEST=Verify that the 'Manage extensions' contextual menu invokes the extensions page. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120045

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : Add todo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/browser/browser_about_handler.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
csilv
+jhawkins for review
8 years, 10 months ago (2012-02-01 00:45:03 UTC) #1
James Hawkins
LGTM. Does this fix clear browsing data dialog? https://chromiumcodereview.appspot.com/9318019/diff/3001/chrome/browser/browser_about_handler.cc File chrome/browser/browser_about_handler.cc (right): https://chromiumcodereview.appspot.com/9318019/diff/3001/chrome/browser/browser_about_handler.cc#newcode137 chrome/browser/browser_about_handler.cc:137: // ...
8 years, 10 months ago (2012-02-01 00:47:09 UTC) #2
csilv
On 2012/02/01 00:47:09, James Hawkins wrote: > LGTM. Does this fix clear browsing data dialog? ...
8 years, 10 months ago (2012-02-01 01:05:54 UTC) #3
csilv
Sorry, here's the correct URL for other CL: https://chromiumcodereview.appspot.com/9309018/
8 years, 10 months ago (2012-02-01 01:07:20 UTC) #4
csilv
https://chromiumcodereview.appspot.com/9318019/diff/3001/chrome/browser/browser_about_handler.cc File chrome/browser/browser_about_handler.cc (right): https://chromiumcodereview.appspot.com/9318019/diff/3001/chrome/browser/browser_about_handler.cc#newcode137 chrome/browser/browser_about_handler.cc:137: // Redirect chrome://settings/extensions. On 2012/02/01 00:47:09, James Hawkins wrote: ...
8 years, 10 months ago (2012-02-01 01:07:37 UTC) #5
James Hawkins
8 years, 10 months ago (2012-02-01 01:10:43 UTC) #6
SLGTM

Powered by Google App Engine
This is Rietveld 408576698