Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1424)

Unified Diff: chrome/browser/ui/browser.cc

Issue 9318019: [uber page] Improve URL mapping for extension URLS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Add todo. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_about_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
===================================================================
--- chrome/browser/ui/browser.cc (revision 119926)
+++ chrome/browser/ui/browser.cc (working copy)
@@ -2250,9 +2250,15 @@
params.path_behavior = browser::NavigateParams::IGNORE_AND_NAVIGATE;
ShowSingletonTabOverwritingNTP(params);
} else {
- browser::NavigateParams params(GetSingletonTabNavigateParams(
- GURL(std::string(chrome::kChromeUIUberURL) +
- chrome::kChromeUISettingsHost + '/' + sub_page)));
+ std::string url;
+ if (sub_page == chrome::kExtensionsSubPage) {
+ url = std::string(chrome::kChromeUIUberURL) +
+ chrome::kChromeUIExtensionsHost;
+ } else {
+ url = std::string(chrome::kChromeUIUberURL) +
+ chrome::kChromeUISettingsHost + '/' + sub_page;
+ }
+ browser::NavigateParams params(GetSingletonTabNavigateParams(GURL(url)));
params.path_behavior = browser::NavigateParams::IGNORE_AND_NAVIGATE;
ShowSingletonTabOverwritingNTP(params);
}
« no previous file with comments | « chrome/browser/browser_about_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698