[uber page] Fix the missing cancel button on the settings search field.

[uber page] Fix the missing cancel button on the settings search field.

On Mac, the search field's cancel button appeared to be missing. This was caused by applying
a transformX() to header elements to allow them to side-scroll properly. This CL changes to
use margin-left instead. The behavior is the same, but now the cancel button appears properly.
I will be filing a WebKit but since this is probably a core issue with the search control.

BUG=112046
TEST=Verify that search field displays a cancel button when not empty.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119999

[csilv, 2012-01-31 21:51:35]

+dbeam for review

[Dan Beam, 2012-01-31 22:08:39]

https://chromiumcodereview.appspot.com/9318009/diff/1/chrome/browser/resource...
File chrome/browser/resources/options2/options_page.js (right):

https://chromiumcodereview.appspot.com/9318009/diff/1/chrome/browser/resource...
chrome/browser/resources/options2/options_page.js:730: var marginLeft =
(document.body.scrollLeft * -1) + 'px';
rtl

[csilv, 2012-01-31 22:43:28]

https://chromiumcodereview.appspot.com/9318009/diff/1/chrome/browser/resource...
File chrome/browser/resources/options2/options_page.js (right):

https://chromiumcodereview.appspot.com/9318009/diff/1/chrome/browser/resource...
chrome/browser/resources/options2/options_page.js:730: var marginLeft =
(document.body.scrollLeft * -1) + 'px';
On 2012/01/31 22:08:39, Dan Beam wrote:
> rtl

Done.

[Dan Beam, 2012-01-31 22:49:49]

https://chromiumcodereview.appspot.com/9318009/diff/5001/chrome/browser/resou...
File chrome/browser/resources/options2/options_page.js (right):

https://chromiumcodereview.appspot.com/9318009/diff/5001/chrome/browser/resou...
chrome/browser/resources/options2/options_page.js:730: var adjust =
document.documentElement.dir == 'rtl' ? 1 : -1;
use isRTL()

https://chromiumcodereview.appspot.com/9318009/diff/5001/chrome/browser/resou...
chrome/browser/resources/options2/options_page.js:731: var marginStart =
(document.body.scrollLeft * adjust) + 'px';
the JavaScript style guide would probably want to you remove these () as neither
order of operations nor * operator are ambiguous.

[csilv, 2012-01-31 23:45:18]

https://chromiumcodereview.appspot.com/9318009/diff/5001/chrome/browser/resou...
File chrome/browser/resources/options2/options_page.js (right):

https://chromiumcodereview.appspot.com/9318009/diff/5001/chrome/browser/resou...
chrome/browser/resources/options2/options_page.js:730: var adjust =
document.documentElement.dir == 'rtl' ? 1 : -1;
On 2012/01/31 22:49:49, Dan Beam wrote:
> use isRTL()

Done.

https://chromiumcodereview.appspot.com/9318009/diff/5001/chrome/browser/resou...
chrome/browser/resources/options2/options_page.js:731: var marginStart =
(document.body.scrollLeft * adjust) + 'px';
On 2012/01/31 22:49:49, Dan Beam wrote:
> the JavaScript style guide would probably want to you remove these () as
neither
> order of operations nor * operator are ambiguous.

Done.

[Dan Beam, 2012-01-31 23:50:22]

lgtm, thanks for updating comments and my hypocritical code, :D (I didn't know
about isRTL() 'til later, thanks for spotting)