Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4538)

Unified Diff: chrome/browser/resources/options2/options_page.js

Issue 9318009: [uber page] Fix the missing cancel button on the settings search field. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Tweak tweak... Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options2/options_page.js
===================================================================
--- chrome/browser/resources/options2/options_page.js (revision 119926)
+++ chrome/browser/resources/options2/options_page.js (working copy)
@@ -723,13 +723,14 @@
};
/**
- * Update the left of all the position: fixed; header elements.
+ * Update the start margin of all the position: fixed; header elements.
* @private
*/
OptionsPage.updateAllHeaderElementPositions_ = function() {
- var translate = 'translateX(' + (document.body.scrollLeft * -1) + 'px)';
+ var adjust = isRTL() ? 1 : -1;
+ var marginStart = document.body.scrollLeft * adjust + 'px';
for (var i = 0; i < this.fixedHeaders_.length; ++i)
- this.fixedHeaders_[i].style.webkitTransform = translate;
+ this.fixedHeaders_[i].style.webkitMarginStart = marginStart;
uber.invokeMethodOnParent('adjustToScroll', document.body.scrollLeft);
};
@@ -740,7 +741,7 @@
* @private
*/
OptionsPage.updateFrozenElementHorizontalPosition_ = function(e) {
- if (document.documentElement.dir == 'rtl')
+ if (isRTL())
e.style.right = HORIZONTAL_OFFSET + 'px';
else
e.style.left = HORIZONTAL_OFFSET - document.body.scrollLeft + 'px';
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698