Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9317077: In test.dart, don't check that the shell or compiler executable exists if we are just listing tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 1b0fe024f683a395be35f3670a19cd4dc23543dc..47738b8107418c1c8c0a59951b58894f9d0d600a 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -964,7 +964,7 @@ class TestUtils {
static String dartShellFileName(Map configuration) {
var name = '${buildDir(configuration)}/${executableName(configuration)}';
- if (!(new File(name)).existsSync()) {
+ if (!(new File(name)).existsSync() && !configuration['list']) {
throw "Executable '$name' does not exist";
}
return name;
@@ -978,7 +978,7 @@ class TestUtils {
if (name == '') {
name = '${buildDir(configuration)}/${compilerName(configuration)}';
}
- if (!(new File(name)).existsSync()) {
+ if (!(new File(name)).existsSync() && !configuration['list']) {
throw "Executable '$name' does not exist";
}
return name;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698