Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 9317077: In test.dart, don't check that the shell or compiler executable exists if we are just listing tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library("test_suite"); 5 #library("test_suite");
6 6
7 #import("dart:io"); 7 #import("dart:io");
8 #import("status_file_parser.dart"); 8 #import("status_file_parser.dart");
9 #import("test_runner.dart"); 9 #import("test_runner.dart");
10 #import("multitest.dart"); 10 #import("multitest.dart");
(...skipping 946 matching lines...) Expand 10 before | Expand all | Expand 10 after
957 case 'frogium': 957 case 'frogium':
958 case 'webdriver': 958 case 'webdriver':
959 return 'frog/bin/frogsh$suffix'; 959 return 'frog/bin/frogsh$suffix';
960 default: 960 default:
961 throw "Unknown compiler for: ${configuration['component']}"; 961 throw "Unknown compiler for: ${configuration['component']}";
962 } 962 }
963 } 963 }
964 964
965 static String dartShellFileName(Map configuration) { 965 static String dartShellFileName(Map configuration) {
966 var name = '${buildDir(configuration)}/${executableName(configuration)}'; 966 var name = '${buildDir(configuration)}/${executableName(configuration)}';
967 if (!(new File(name)).existsSync()) { 967 if (!(new File(name)).existsSync() && !configuration['list']) {
968 throw "Executable '$name' does not exist"; 968 throw "Executable '$name' does not exist";
969 } 969 }
970 return name; 970 return name;
971 } 971 }
972 972
973 static String compilerPath(Map configuration) { 973 static String compilerPath(Map configuration) {
974 if (configuration['component'] == 'dartium') { 974 if (configuration['component'] == 'dartium') {
975 return null; // No separate compiler for dartium tests. 975 return null; // No separate compiler for dartium tests.
976 } 976 }
977 var name = configuration['frog']; 977 var name = configuration['frog'];
978 if (name == '') { 978 if (name == '') {
979 name = '${buildDir(configuration)}/${compilerName(configuration)}'; 979 name = '${buildDir(configuration)}/${compilerName(configuration)}';
980 } 980 }
981 if (!(new File(name)).existsSync()) { 981 if (!(new File(name)).existsSync() && !configuration['list']) {
982 throw "Executable '$name' does not exist"; 982 throw "Executable '$name' does not exist";
983 } 983 }
984 return name; 984 return name;
985 } 985 }
986 986
987 static String outputDir(Map configuration) { 987 static String outputDir(Map configuration) {
988 var outputDir = ''; 988 var outputDir = '';
989 var system = configuration['system']; 989 var system = configuration['system'];
990 if (system == 'linux') { 990 if (system == 'linux') {
991 outputDir = 'out/'; 991 outputDir = 'out/';
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
1071 * $noCrash tests are expected to be flaky but not crash 1071 * $noCrash tests are expected to be flaky but not crash
1072 * $pass tests are expected to pass 1072 * $pass tests are expected to pass
1073 * $failOk tests are expected to fail that we won't fix 1073 * $failOk tests are expected to fail that we won't fix
1074 * $fail tests are expected to fail that we should fix 1074 * $fail tests are expected to fail that we should fix
1075 * $crash tests are expected to crash that we should fix 1075 * $crash tests are expected to crash that we should fix
1076 * $timeout tests are allowed to timeout 1076 * $timeout tests are allowed to timeout
1077 """; 1077 """;
1078 print(report); 1078 print(report);
1079 } 1079 }
1080 } 1080 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698