Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1812)

Unified Diff: chrome/renderer/extensions/chrome_v8_context.cc

Issue 9317072: Allow omitting optional parameters for Extensions API functions (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Don't need this custom binding anymore. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/chrome_v8_context.cc
diff --git a/chrome/renderer/extensions/chrome_v8_context.cc b/chrome/renderer/extensions/chrome_v8_context.cc
index 98b0c077573cf934e0882ad1b7638516bdab2707..436f02421e9e983f87b0666308f480413db4419e 100644
--- a/chrome/renderer/extensions/chrome_v8_context.cc
+++ b/chrome/renderer/extensions/chrome_v8_context.cc
@@ -20,6 +20,7 @@ const char kChromeHidden[] = "chromeHidden";
#ifndef NDEBUG
const char kValidateCallbacks[] = "validateCallbacks";
+const char kValidateAPI[] = "validateAPI";
#endif
} // namespace
@@ -58,6 +59,9 @@ v8::Handle<v8::Value> ChromeV8Context::GetOrCreateChromeHidden(
// against their schema definitions.
v8::Local<v8::Object>::Cast(hidden)
->Set(v8::String::New(kValidateCallbacks), v8::True());
+ // Tell schema_generated_bindings.js to validate API for ambiguity.
+ v8::Local<v8::Object>::Cast(hidden)
+ ->Set(v8::String::New(kValidateAPI), v8::True());
Aaron Boodman 2012/02/06 01:30:52 Formatting should be: v8::Local<v8::Object>::Cast
Matt Perry 2012/02/06 21:34:57 btw, the reason for this is that Chrome style is t
#endif
}

Powered by Google App Engine
This is Rietveld 408576698