Allow omitting optional parameters for Extensions API functions

chrome/renderer/extensions/chrome_v8_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/chrome_v8_context.h"
 
 #include "base/logging.h"
 #include "base/string_split.h"
 #include "base/values.h"
 #include "chrome/common/extensions/extension_set.h"
 #include "chrome/renderer/extensions/chrome_v8_extension.h"
 #include "content/public/renderer/render_view.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
 #include "v8/include/v8.h"
 
 namespace {
 
 const char kChromeHidden[] = "chromeHidden";
 
 #ifndef NDEBUG
 const char kValidateCallbacks[] = "validateCallbacks";
+const char kValidateAPI[] = "validateAPI";
 #endif
 
 }  // namespace
 
 
 ChromeV8Context::ChromeV8Context(v8::Handle<v8::Context> v8_context,
                                  WebKit::WebFrame* web_frame,
                                  const std::string& extension_id)
     : v8_context_(v8::Persistent<v8::Context>::New(v8_context)),
       web_frame_(web_frame),
@@ skipping 18 matching lines @@
 
   if (hidden.IsEmpty() || hidden->IsUndefined()) {
     hidden = v8::Object::New();
     global->SetHiddenValue(v8::String::New(kChromeHidden), hidden);
 
 #ifndef NDEBUG
     // Tell schema_generated_bindings.js to validate callbacks and events
     // against their schema definitions.
     v8::Local<v8::Object>::Cast(hidden)
         ->Set(v8::String::New(kValidateCallbacks), v8::True());
+    // Tell schema_generated_bindings.js to validate API for ambiguity.
+    v8::Local<v8::Object>::Cast(hidden)
+        ->Set(v8::String::New(kValidateAPI), v8::True());

[Aaron Boodman, 2012/02/06 01:30:52]

Formatting should be:

v8::Local<v8::Object>::Cast(hidden)->Set(
    ... rest indented four ...

[Matt Perry, 2012/02/06 21:34:57]

btw, the reason for this is that Chrome style is to wrap with the operator at
the end of the preceding line. also acceptable is 
...Cast(hidden)->
    Set(...)

 #endif
   }
 
   DCHECK(hidden->IsObject());
   return v8::Local<v8::Object>::Cast(hidden);
 }
 
 v8::Handle<v8::Value> ChromeV8Context::GetChromeHidden() const {
   v8::Local<v8::Object> global = v8_context_->Global();
   return global->GetHiddenValue(v8::String::New(kChromeHidden));
@@ skipping 49 matching lines @@
   argv[1] = v8::Boolean::New(is_extension_process);
   argv[2] = v8::Boolean::New(is_incognito_process);
   argv[3] = v8::Integer::New(manifest_version);
   CallChromeHiddenMethod("dispatchOnLoad", arraysize(argv), argv, NULL);
 }
 
 void ChromeV8Context::DispatchOnUnloadEvent() const {
   v8::HandleScope handle_scope;
   CallChromeHiddenMethod("dispatchOnUnload", 0, NULL, NULL);
 }