Issue 9317042: Merge 120123 - Fix crash in ExtensionService::InitializePermissions().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9317042: Merge 120123 - Fix crash in ExtensionService::InitializePermissions(). (Closed)

Created:
8 years, 10 months ago by jstritar

Modified:
8 years, 10 months ago

Reviewers:
jstritar

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1025/src/

Visibility:
Public.

Merge 120123 - Fix crash in ExtensionService::InitializePermissions(). This crash occurs when an unpacked extension changes IDs by adding a key to its manifest. The extension preferences are stored under the old key. This started causing problems because now we record granted permissions for unpacked extensions. BUG=112301 TEST=ExtensionServiceTest.UnpackedExtensionCanChangeID Review URL: https://chromiumcodereview.appspot.com/9320021 TBR=jstritar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120127

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -5 lines)			Patch
M	chrome/browser/extensions/extension_service_unittest.cc	View	2 chunks	+45 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/installed_loader.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/permissions_updater.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/test/data/extensions/unpacked/manifest_no_key.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/unpacked/manifest_with_key.json	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)