Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: remoting/host/plugin/daemon_npapi_linux.cc

Issue 9316078: Added daemon process NPAPI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed unused headers. Fixed Windows and Mac builds. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/plugin/daemon_npapi_linux.cc
diff --git a/remoting/host/plugin/daemon_npapi_linux.cc b/remoting/host/plugin/daemon_npapi_linux.cc
new file mode 100644
index 0000000000000000000000000000000000000000..536e06996be03ac6ad16c9c69974420b1c87a60d
--- /dev/null
+++ b/remoting/host/plugin/daemon_npapi_linux.cc
@@ -0,0 +1,38 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/host/plugin/daemon_npapi.h"
Sergey Ulanov 2012/02/02 23:41:24 nit: empty line after this include
Jamie 2012/02/03 00:47:41 Done.
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+
+namespace {
+class DaemonNpapiLinux : public remoting::DaemonNpapi {
+ public:
+ DaemonNpapiLinux();
+
+ virtual State GetState() OVERRIDE;
+ virtual void Start(const char* pin) OVERRIDE;
+ virtual void Stop() OVERRIDE;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(DaemonNpapiLinux);
+};
+} // namespace
+
+DaemonNpapiLinux::DaemonNpapiLinux() {
Sergey Ulanov 2012/02/02 23:41:24 nit: should this be in the nameless namespace wher
Jamie 2012/02/03 00:47:41 For consistency with other uses of a similar patte
+}
+
+remoting::DaemonNpapi::State DaemonNpapiLinux::GetState() {
+ return remoting::DaemonNpapi::STATE_NOT_INSTALLED;
+}
+
+void DaemonNpapiLinux::Start(const char* pin) {
Wez 2012/02/03 01:25:36 nit: NOTIMPLEMENTED()?
Jamie 2012/02/03 01:40:15 Done.
+}
+
+void DaemonNpapiLinux::Stop() {
Wez 2012/02/03 01:25:36 nit: Ditto.
Jamie 2012/02/03 01:40:15 Done.
+}
+
+remoting::DaemonNpapi* remoting::DaemonNpapi::Create() {
Sergey Ulanov 2012/02/02 23:41:24 nit put this in namespace remoting { }?
Jamie 2012/02/03 00:47:41 Done.
+ return new DaemonNpapiLinux();
+}

Powered by Google App Engine
This is Rietveld 408576698