Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: remoting/host/plugin/daemon_npapi_linux.cc

Issue 9316078: Added daemon process NPAPI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed unused headers. Fixed Windows and Mac builds. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "remoting/host/plugin/daemon_npapi.h"
Sergey Ulanov 2012/02/02 23:41:24 nit: empty line after this include
Jamie 2012/02/03 00:47:41 Done.
6 #include "base/basictypes.h"
7 #include "base/compiler_specific.h"
8
9 namespace {
10 class DaemonNpapiLinux : public remoting::DaemonNpapi {
11 public:
12 DaemonNpapiLinux();
13
14 virtual State GetState() OVERRIDE;
15 virtual void Start(const char* pin) OVERRIDE;
16 virtual void Stop() OVERRIDE;
17
18 private:
19 DISALLOW_COPY_AND_ASSIGN(DaemonNpapiLinux);
20 };
21 } // namespace
22
23 DaemonNpapiLinux::DaemonNpapiLinux() {
Sergey Ulanov 2012/02/02 23:41:24 nit: should this be in the nameless namespace wher
Jamie 2012/02/03 00:47:41 For consistency with other uses of a similar patte
24 }
25
26 remoting::DaemonNpapi::State DaemonNpapiLinux::GetState() {
27 return remoting::DaemonNpapi::STATE_NOT_INSTALLED;
28 }
29
30 void DaemonNpapiLinux::Start(const char* pin) {
Wez 2012/02/03 01:25:36 nit: NOTIMPLEMENTED()?
Jamie 2012/02/03 01:40:15 Done.
31 }
32
33 void DaemonNpapiLinux::Stop() {
Wez 2012/02/03 01:25:36 nit: Ditto.
Jamie 2012/02/03 01:40:15 Done.
34 }
35
36 remoting::DaemonNpapi* remoting::DaemonNpapi::Create() {
Sergey Ulanov 2012/02/02 23:41:24 nit put this in namespace remoting { }?
Jamie 2012/02/03 00:47:41 Done.
37 return new DaemonNpapiLinux();
38 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698