Issue 9316029: Include ui_strings in aura_shell_unittests to fix the build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9316029: Include ui_strings in aura_shell_unittests to fix the build (Closed)

Created:
8 years, 10 months ago by Zachary Kuznia

Modified:
8 years, 10 months ago

Reviewers:
tony, sky

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Include ui_strings in aura_shell_unittests to fix the build BUG=None TEST=Run aura_shell_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120053

Patch Set 2 : Remove a comment #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -1 line)			Patch
	M	ash/ash.gyp	View		3 chunks	+38 lines, -0 lines	0 comments	Download
	M	ash/test/test_suite.cc	View	1	1 chunk	+6 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Zachary Kuznia

Hi sky, tony, Could you review this CL at https://chromiumcodereview.appspot.com/9316029 I've committed it already to ...

8 years, 10 months ago (2012-02-01 10:43:48 UTC) #1

tony

LG https://chromiumcodereview.appspot.com/9316029/diff/2001/ash/test/test_suite.cc File ash/test/test_suite.cc (right): https://chromiumcodereview.appspot.com/9316029/diff/2001/ash/test/test_suite.cc#newcode39 ash/test/test_suite.cc:39: #endif // defined(OS_MACOSX) This works, but it may ...

8 years, 10 months ago (2012-02-03 02:17:05 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 9316029: Include ui_strings in aura_shell_unittests to fix the build (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove a comment #

Messages