Make the Chrome Web Store Icon Syncable

chrome/browser/extensions/extension_service.cc

Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 6fe5f1eb5e33ce1b4fc0e7410b12ce650183f979..3bcb9042215f9a3cfd78823a72a6e3f9c84224d1 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -1584,7 +1584,6 @@ void ExtensionService::SetIsIncognitoEnabled(
   const Extension* extension = GetInstalledExtension(extension_id);
   if (extension && extension->location() == Extension::COMPONENT) {
     // This shouldn't be called for component extensions.
-    NOTREACHED();

[Finnur, 2012/02/01 09:18:57]

Why is this needed?

[csharp, 2012/02/01 14:48:23]

I took this out because when when the sync data for the CWS is read, it calls
this function, which reaches the NOTREACHED (since the CWS is a component),
which causes a crash in debug.

[Finnur, 2012/02/01 15:09:10]

Then why not DCHECK if...
  extension_id != extension_misc::kWebStoreAppId
... instead?

[csharp, 2012/02/01 15:32:26]

I'd wanted to avoid making too many special cases for the WebStoreApp, but that
is probably a good idea to idea that check (since the webstoreapp is already
such a special case).

     return;
   }