Make the Chrome Web Store Icon Syncable

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 1566 matching lines @@
 
   // Check the prefs.
   return extension_prefs_->IsIncognitoEnabled(extension_id);
 }
 
 void ExtensionService::SetIsIncognitoEnabled(
     const std::string& extension_id, bool enabled) {
   const Extension* extension = GetInstalledExtension(extension_id);
   if (extension && extension->location() == Extension::COMPONENT) {
     // This shouldn't be called for component extensions.
-    NOTREACHED();

[Finnur, 2012/02/01 09:18:57]

Why is this needed?

[csharp, 2012/02/01 14:48:23]

I took this out because when when the sync data for the CWS is read, it calls
this function, which reaches the NOTREACHED (since the CWS is a component),
which causes a crash in debug.

[Finnur, 2012/02/01 15:09:10]

Then why not DCHECK if...
  extension_id != extension_misc::kWebStoreAppId
... instead?

[csharp, 2012/02/01 15:32:26]

I'd wanted to avoid making too many special cases for the WebStoreApp, but that
is probably a good idea to idea that check (since the webstoreapp is already
such a special case).

     return;
   }
 
   // Broadcast unloaded and loaded events to update browser state. Only bother
   // if the value changed and the extension is actually enabled, since there is
   // no UI otherwise.
   bool old_enabled = extension_prefs_->IsIncognitoEnabled(extension_id);
   if (enabled == old_enabled)
     return;
 
@@ skipping 1104 matching lines @@
   //
   // To coexist with certain unit tests that don't have an IO thread message
   // loop available at ExtensionService shutdown, we lazy-initialize this
   // object so that those cases neither create nor destroy a SocketController.
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   if (!socket_controller_) {
     socket_controller_ = new extensions::SocketController();
   }
   return socket_controller_;
 }