Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 9309097: Revert 120018 - Revert 120005 - Enabled pressing TAB to traverse through the Omnibox results, rem... (Closed)

Created:
8 years, 10 months ago by Peter Kasting
Modified:
8 years, 10 months ago
Reviewers:
kinuko, Mike Mammarella
CC:
chromium-reviews, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Revert 120018 - Revert 120005 - Enabled pressing TAB to traverse through the Omnibox results, removed moving the caret to the end of the line with TAB, and filtered out redundant URLs. This adds the ability to move through Omnibox result matches using TAB in addition to the arrow keys. To enable this, pressing TAB to move the caret to the end of the line was removed and the keyword hint/shortcut logic has been modified. The Omnibox popup now shows keyword markers on the right side of matches that have associated keywords (represented by a right arrow). When this kind of match is selected, and the keyword is accepted, the match changes appearance by animating in the associated keyword match from the right to display the "Search X for <>" message. If multiple matches have the same keyword then only the most relevant match will display the keyword marker and hint. Pressing TAB while a keyword hint is shown will enter keyword mode in place; the results will no longer change when keyword mode is entered. Additionally, substituting keyword provider matches will only be shown if a keyword substitution is available. Finally, results with redundant destination URLs (e.g., "foo.com", "www.foo.com") will have the less relevant URLs filtered out. This also addresses some GTK omnibox browsertest flakiness; see bug 112041. Contributed by aaron.randolph@gmail.com BUG=57748, 76278, 77662, 80934, 84420 TEST=Press TAB to move the selection down the list of results, SHIFT+TAB to move up. Review URL: http://codereview.chromium.org/6731036 TBR=aaron.randolph@gmail.com Review URL: https://chromiumcodereview.appspot.com/9310017 TBR=kinuko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120448

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+993 lines, -491 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete.h View 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete.cc View 5 chunks +49 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.cc View 7 chunks +53 lines, -19 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.h View 6 chunks +37 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.cc View 4 chunks +78 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_model.h View 7 chunks +22 lines, -15 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_model.cc View 6 chunks +27 lines, -60 lines 0 comments Download
D chrome/browser/autocomplete/autocomplete_popup_model_unittest.cc View 1 chunk +0 lines, -118 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_unittest.cc View 11 chunks +134 lines, -17 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/keyword_provider.h View 5 chunks +23 lines, -10 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider.cc View 10 chunks +111 lines, -61 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider_unittest.cc View 2 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h View 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 9 chunks +31 lines, -31 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc View 5 chunks +28 lines, -18 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 7 chunks +132 lines, -34 lines 1 comment Download
M chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc View 8 chunks +28 lines, -19 lines 0 comments Download
M chrome/browser/ui/views/autocomplete/autocomplete_result_view.h View 6 chunks +24 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc View 7 chunks +98 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 3 chunks +16 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 4 chunks +20 lines, -16 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/keycodes/keyboard_code_conversion_mac.mm View 2 chunks +2 lines, -1 line 0 comments Download
M ui/base/keycodes/keyboard_codes_posix.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
8 years, 10 months ago (2012-02-04 00:30:31 UTC) #1
Mike Mammarella
8 years, 10 months ago (2012-02-04 01:47:57 UTC) #2
https://chromiumcodereview.appspot.com/9309097/diff/1/chrome/browser/ui/omnib...
File chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (right):

https://chromiumcodereview.appspot.com/9309097/diff/1/chrome/browser/ui/omnib...
chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:165: virtual void
OnBeforeShowBrowser(Browser* browser) {
FYI, this part should no longer be necessary.

Powered by Google App Engine
This is Rietveld 408576698