Issue 9307050: Memory leak at NativeObjectsExplorer::FindOrAddGroupInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9307050: Memory leak at NativeObjectsExplorer::FindOrAddGroupInfo (Closed)

Created:
8 years, 10 months ago by loislo

Modified:
8 years, 10 months ago

Reviewers:
mnaganov (inactive)

CC:
mnaganov (inactive)

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Using local file src/sconsbuild/Debug/test_shell_tests. Leak of 16 bytes in 1 objects allocated from: @ 8c06b85 v8::internal::NativeObjectsExplorer::FindOrAddGroupInfo BUG=112315 TEST=heapcheck build

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	src/profile-generator.cc	View		2 chunks	+8 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

LGTM with a comment. https://chromiumcodereview.appspot.com/9307050/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/9307050/diff/1/src/profile-generator.cc#newcode2826 src/profile-generator.cc:2826: hash_(reinterpret_cast<intptr_t>(label)), BTW, you should use ...

8 years, 10 months ago (2012-02-02 12:00:46 UTC) #2

loislo

8 years, 10 months ago (2012-02-02 13:26:10 UTC) #3

On 2012/02/02 12:00:46, Mikhail Naganov (Chromium) wrote:
> LGTM with a comment.
> 
> https://chromiumcodereview.appspot.com/9307050/diff/1/src/profile-generator.cc
> File src/profile-generator.cc (right):
> 
>
https://chromiumcodereview.appspot.com/9307050/diff/1/src/profile-generator.c...
> src/profile-generator.cc:2826: hash_(reinterpret_cast<intptr_t>(label)),
> BTW, you should use ComputeIntegerHash here for better distribution.

I'll do that separately.

Expand Messages | Collapse Messages