Memory leak at NativeObjectsExplorer::FindOrAddGroupInfo

src/profile-generator.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2702 matching lines @@
   for (HashMap::Entry* p = objects_by_info_.Start();
        p != NULL;
        p = objects_by_info_.Next(p)) {
     v8::RetainedObjectInfo* info =
         reinterpret_cast<v8::RetainedObjectInfo*>(p->key);
     info->Dispose();
     List<HeapObject*>* objects =
         reinterpret_cast<List<HeapObject*>* >(p->value);
     delete objects;
   }
+  for (HashMap::Entry* p = native_groups_.Start();
+       p != NULL;
+       p = native_groups_.Next(p)) {
+    v8::RetainedObjectInfo* info =
+        reinterpret_cast<v8::RetainedObjectInfo*>(p->value);
+    info->Dispose();
+  }
 }
 
 
 HeapEntry* NativeObjectsExplorer::AllocateEntry(
     HeapThing ptr, int children_count, int retainers_count) {
   v8::RetainedObjectInfo* info =
       reinterpret_cast<v8::RetainedObjectInfo*>(ptr);
   intptr_t elements = info->GetElementCount();
   intptr_t size = info->GetSizeInBytes();
   return snapshot_->AddEntry(
@@ skipping 76 matching lines @@
   SetRootNativeRootsReference();
   filler_ = NULL;
   return true;
 }
 
 
 class NativeGroupRetainedObjectInfo : public v8::RetainedObjectInfo {
  public:
   explicit NativeGroupRetainedObjectInfo(const char* label)
       : disposed_(false),
         hash_(reinterpret_cast<intptr_t>(label)),

[mnaganov (inactive), 2012/02/02 12:00:46]

BTW, you should use ComputeIntegerHash here for better distribution. 

         label_(label) {
   }
 
   virtual ~NativeGroupRetainedObjectInfo() {}
   virtual void Dispose() {
     CHECK(!disposed_);
     disposed_ = true;
+    delete this;
   }
   virtual bool IsEquivalent(RetainedObjectInfo* other) {
     return hash_ == other->GetHash() && !strcmp(label_, other->GetLabel());
   }
   virtual intptr_t GetHash() { return hash_; }
   virtual const char* GetLabel() { return label_; }
 
  private:
   bool disposed_;
   intptr_t hash_;
@@ skipping 822 matching lines @@
 
 
 void HeapSnapshotJSONSerializer::SortHashMap(
     HashMap* map, List<HashMap::Entry*>* sorted_entries) {
   for (HashMap::Entry* p = map->Start(); p != NULL; p = map->Next(p))
     sorted_entries->Add(p);
   sorted_entries->Sort(SortUsingEntryValue);
 }
 
 } }  // namespace v8::internal