Issue 9307024: Make IRT load failure fatal under Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9307024: Make IRT load failure fatal under Chrome (Closed)

Created:
8 years, 10 months ago by Roland McGrath

Modified:
8 years, 10 months ago

Reviewers:
Mark Seaborn, sehr (please use chromium), bennet.yee

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

Make IRT load failure fatal under Chrome We don't want the loader to just keep going if there is a failure to load the IRT image in the native Chrome case. It's better to fail early than to start running a nexe and have it fail obscurely for lack of an IRT. BUG= http://code.google.com/p/nativeclient/issues/detail?id=1691 TEST= chrome_browser_tests irt=0 disable_dynamic_plugin_loading=1 has no regressions with a modified Chrome R=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=7720

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -12 lines)			Patch
	M	src/trusted/service_runtime/sel_main_chrome.c	View		3 chunks	+5 lines, -12 lines	0 comments	Download

Total messages: 4 (0 generated)

Roland McGrath

Seeking a reviewer not skiing or conferring. PTAL

8 years, 10 months ago (2012-02-01 18:29:21 UTC) #2

lgtm (by phone)