Make IRT load failure fatal under Chrome

src/trusted/service_runtime/sel_main_chrome.c

 /*
- * Copyright (c) 2011 The Native Client Authors. All rights reserved.
+ * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "native_client/src/include/portability.h"
 #include "native_client/src/include/portability_io.h"
 
 #if NACL_OSX
 #include <crt_externs.h>
 #endif
@@ skipping 27 matching lines @@
 void NaClSetIrtFileDesc(int fd) {
   CHECK(g_irt_file_desc == -1);
   g_irt_file_desc = fd;
 }
 
 static void NaClLoadIrt(struct NaClApp *nap) {
   int file_desc;
   struct GioPio gio_pio;
   struct Gio *gio_desc;
 
-  /*
-   * TODO(mseaborn): Eventually we should make the two warnings below
-   * into errors, and require use of the IRT.
-   * See http://code.google.com/p/nativeclient/issues/detail?id=1691
-   */
   if (g_irt_file_desc == -1) {
-    NaClLog(0, "NaClLoadIrt: Integrated runtime (IRT) not present.  "
-            "Continuing anyway.\n");
-    return;
+    NaClLog(LOG_FATAL, "NaClLoadIrt: Integrated runtime (IRT) not present.\n");
   }
 
   file_desc = DUP(g_irt_file_desc);
   if (file_desc < 0) {
     NaClLog(LOG_FATAL, "NaClLoadIrt: Failed to dup() file descriptor\n");
   }
 
   /*
    * The GioPio type is safe to use when this file descriptor is shared
    * with other processes, because it does not use the shared file position.
    */
   if (!GioPioCtor(&gio_pio, file_desc)) {
     NaClLog(LOG_FATAL, "NaClLoadIrt: Failed to create Gio wrapper\n");
   }
   gio_desc = (struct Gio *) &gio_pio;
 
   if (NaClAppLoadFileDynamically(nap, gio_desc) != LOAD_OK) {
-    NaClLog(0, "NaClLoadIrt: Failed to load the integrated runtime (IRT).  "
-            "The user executable was probably not built to use the IRT.  "
-            "Continuing anyway.\n");
+    NaClLog(LOG_FATAL,
+            "NaClLoadIrt: Failed to load the integrated runtime (IRT).  "
+            "The user executable was probably not built to use the IRT.\n");
   }
 
   (*NACL_VTBL(Gio, gio_desc)->Close)(gio_desc);
   (*NACL_VTBL(Gio, gio_desc)->Dtor)(gio_desc);
 }
 
 void NaClMainForChromium(int handle_count, const NaClHandle *handles,
                          int debug) {
   char *av[1];
   int ac = 1;
@@ skipping 212 matching lines @@
   if (LOAD_OK != errcode) {
     NaClBlockIfCommandChannelExists(nap);
   }
 
  done_ctor:
 
   NaClAllModulesFini();
 
   NaClExit(ret_code);
 }