Issue 9302029: Revert 119841 - Implementation of GCAPI reactivation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9302029: Revert 119841 - Implementation of GCAPI reactivation. (Closed)

Created:
8 years, 10 months ago by Lei Zhang

Modified:
8 years, 10 months ago

Reviewers:
robertshield

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 119841 - Implementation of GCAPI reactivation. Also, some cleanup in gcapi_tests such that it now only runs gtest tests by default. BUG=111453 TEST=gcapi_tests.exe Review URL: https://chromiumcodereview.appspot.com/9288056 TBR=robertshield@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119865

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -413 lines)			Patch
M	chrome/chrome_installer.gypi	View	4 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/installer/gcapi/gcapi.h	View	3 chunks	+2 lines, -43 lines	0 comments	Download
M	chrome/installer/gcapi/gcapi.cc	View	2 chunks	+0 lines, -72 lines	0 comments	Download
M	chrome/installer/gcapi/gcapi.def	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/installer/gcapi/gcapi_reactivation.h	View	1 chunk	+0 lines, -19 lines	0 comments	Download
D	chrome/installer/gcapi/gcapi_reactivation.cc	View	1 chunk	+0 lines, -77 lines	0 comments	Download
D	chrome/installer/gcapi/gcapi_reactivation_test.cc	View	1 chunk	+0 lines, -186 lines	0 comments	Download
M	chrome/installer/gcapi/gcapi_test.cc	View	2 chunks	+3 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

8 years, 10 months ago (2012-01-31 06:37:02 UTC) #2

Several Win bots failed:
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/bu...
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/bu...
http://build.chromium.org/p/chromium/builders/Win/builds/9281

Expand Messages | Collapse Messages