Implementation of GCAPI reactivation.

Implementation of GCAPI reactivation.

Also, some cleanup in gcapi_tests such that it now only runs gtest tests by default.

BUG=111453
TEST=gcapi_tests.exe

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119841

[Roger Tawa OOO till Jul 10th, 2012-01-29 16:32:42]

Hi Robert, some quesions below.

http://codereview.chromium.org/9288056/diff/3007/chrome/chrome_installer.gypi
File chrome/chrome_installer.gypi (right):

http://codereview.chromium.org/9288056/diff/3007/chrome/chrome_installer.gypi...
chrome/chrome_installer.gypi:29: 'installer/gcapi/gcapi_reactivation.h',
for my own info, why doesn't gcapi_dll depnd on gcapi_lib, that way you don't
need to duplicate the .cc and .h files?

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi.cc
File chrome/installer/gcapi/gcapi.cc (right):

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi...
chrome/installer/gcapi/gcapi.cc:610: // SetOmahaExptLabel (ReacBrandCode,
weekNumber);
should this have been commented out?

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi.h
File chrome/installer/gcapi/gcapi.h (right):

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi...
chrome/installer/gcapi/gcapi.h:95: typedef BOOL (__stdcall
*GCCC_ReactivateChrome)(const wchar_t*, DWORD*);
the args for these two typedefs does not seem to match the functions above.

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi...
File chrome/installer/gcapi/gcapi_reactivation.cc (right):

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi...
chrome/installer/gcapi/gcapi_reactivation.cc:38: success = true;
no need for local var if you return true here and return false below.

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi...
File chrome/installer/gcapi/gcapi_test.cc (right):

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi...
chrome/installer/gcapi/gcapi_test.cc:70: }
what's this check for?

[robertshield, 2012-01-30 02:40:39]

Thanks Roger, PTAL

http://codereview.chromium.org/9288056/diff/3007/chrome/chrome_installer.gypi
File chrome/chrome_installer.gypi (right):

http://codereview.chromium.org/9288056/diff/3007/chrome/chrome_installer.gypi...
chrome/chrome_installer.gypi:29: 'installer/gcapi/gcapi_reactivation.h',
On 2012/01/29 16:32:42, Roger Tawa wrote:
> for my own info, why doesn't gcapi_dll depnd on gcapi_lib, that way you don't
> need to duplicate the .cc and .h files?

Doesn't look like there's a good reason. I followed what was already there. I
removed the duplicate source files from the dll project and all seems to work.

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi.cc
File chrome/installer/gcapi/gcapi.cc (right):

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi...
chrome/installer/gcapi/gcapi.cc:610: // SetOmahaExptLabel (ReacBrandCode,
weekNumber);
On 2012/01/29 16:32:42, Roger Tawa wrote:
> should this have been commented out?

Yes, actually I meant to make that a TODO and do it in another CL. Changed.

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi.h
File chrome/installer/gcapi/gcapi.h (right):

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi...
chrome/installer/gcapi/gcapi.h:95: typedef BOOL (__stdcall
*GCCC_ReactivateChrome)(const wchar_t*, DWORD*);
On 2012/01/29 16:32:42, Roger Tawa wrote:
> the args for these two typedefs does not seem to match the functions above.

Done.

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi...
File chrome/installer/gcapi/gcapi_reactivation.cc (right):

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi...
chrome/installer/gcapi/gcapi_reactivation.cc:38: success = true;
On 2012/01/29 16:32:42, Roger Tawa wrote:
> no need for local var if you return true here and return false below.

True, but that can cause more code to be generated: calls to the destructors of
the non-POD data-types will be duplicated. 

I also prefer minimizing the number of return statements in a function where
doing so won't hurt readability.  (CanOfferReactivation() in gcapi.cc  is a
counter-example where readability would suffer imo).

All this to say I feel this structure has merit but I'll change it if you really
want me to. :-)

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi...
File chrome/installer/gcapi/gcapi_test.cc (right):

http://codereview.chromium.org/9288056/diff/3007/chrome/installer/gcapi/gcapi...
chrome/installer/gcapi/gcapi_test.cc:70: }
On 2012/01/29 16:32:42, Roger Tawa wrote:
> what's this check for?

Before I started messing around in gcapi, the tests weren't gtests, but rather
an exe that calls a couple of the dll exports, presumably to see whether they
appear to do something or crash. This had the annoying side effect of spawning
top level Chrome windows whenever the tests were run.

I haven't deleted this old behaviour since I believe Mike may still use it, but
i have hidden it behind a flag that I can tell him about if he comes asking.

[Roger Tawa OOO till Jul 10th, 2012-01-30 03:47:45]

lgtm

No need to change return statements.

[commit-bot: I haz the power, 2012-01-30 18:32:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/9288056/8002

[commit-bot: I haz the power, 2012-01-30 18:32:52]

Presubmit check for 9288056-8002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling an API that accepts a
wstring, fix the API.
    chrome/installer/gcapi/gcapi.cc:576
    chrome/installer/gcapi/gcapi_reactivation.cc:17
    chrome/installer/gcapi/gcapi_reactivation.cc:18
    chrome/installer/gcapi/gcapi_reactivation.cc:28
    chrome/installer/gcapi/gcapi_reactivation.cc:35
    chrome/installer/gcapi/gcapi_reactivation.cc:47
    chrome/installer/gcapi/gcapi_reactivation.cc:50
    chrome/installer/gcapi/gcapi_reactivation.h:15
    chrome/installer/gcapi/gcapi_reactivation.h:17

Presubmit checks took 1.3s to calculate.