Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 9296001: WebSocket Pepper API: Remove binary type handling interfaces (Closed)

Created:
8 years, 11 months ago by Takashi Toyoshima
Modified:
8 years, 11 months ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

WebSocket Pepper API: Remove binary type handling interfaces In an API discussion, we decide to remove binary type handling interfaces from the first release. This change just fix the interface. The change to make the interface out of dev will follow this change. BUG=87310 TEST=ui_test --gtest_filter='*WebSocket*' Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119382

Patch Set 1 : for review #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -461 lines) Patch
M ppapi/api/dev/ppb_websocket_dev.idl View 5 chunks +6 lines, -66 lines 0 comments Download
M ppapi/c/dev/ppb_websocket_dev.h View 7 chunks +9 lines, -89 lines 0 comments Download
M ppapi/cpp/dev/websocket_dev.h View 3 chunks +4 lines, -29 lines 0 comments Download
M ppapi/cpp/dev/websocket_dev.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_websocket_rpc_server.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_websocket.cc View 2 chunks +1 line, -39 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_server.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppb_websocket.srpc View 1 chunk +0 lines, -13 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/trusted/srpcgen/ppb_rpc.h View 1 chunk +0 lines, -11 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/untrusted/srpcgen/ppb_rpc.h View 1 chunk +0 lines, -9 lines 0 comments Download
M ppapi/tests/test_websocket.cc View 1 4 chunks +0 lines, -8 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_websocket_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_websocket_thunk.cc View 2 chunks +0 lines, -38 lines 0 comments Download
M webkit/plugins/ppapi/ppb_websocket_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/ppb_websocket_impl.cc View 1 3 chunks +1 line, -34 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Takashi Toyoshima
This is a CL just to change the API. I'll land this before out of ...
8 years, 11 months ago (2012-01-27 01:26:22 UTC) #1
dmichael (off chromium)
lgtm http://codereview.chromium.org/9296001/diff/2001/ppapi/api/dev/ppb_websocket_dev.idl File ppapi/api/dev/ppb_websocket_dev.idl (right): http://codereview.chromium.org/9296001/diff/2001/ppapi/api/dev/ppb_websocket_dev.idl#newcode10 ppapi/api/dev/ppb_websocket_dev.idl:10: M17 = 0.1 M18 = 0.91 ? I ...
8 years, 11 months ago (2012-01-27 01:44:42 UTC) #2
Takashi Toyoshima
http://codereview.chromium.org/9296001/diff/2001/ppapi/api/dev/ppb_websocket_dev.idl File ppapi/api/dev/ppb_websocket_dev.idl (right): http://codereview.chromium.org/9296001/diff/2001/ppapi/api/dev/ppb_websocket_dev.idl#newcode10 ppapi/api/dev/ppb_websocket_dev.idl:10: M17 = 0.1 Actually, the final API is totally ...
8 years, 11 months ago (2012-01-27 01:57:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/9296001/2001
8 years, 11 months ago (2012-01-27 02:22:44 UTC) #4
Takashi Toyoshima
8 years, 11 months ago (2012-01-27 05:21:39 UTC) #5
Might conflict with ArrayBuffe change, and tree is throttled.
CQ granted this change, so I'll land rebased change via dcommit.

Powered by Google App Engine
This is Rietveld 408576698