Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: ppapi/cpp/dev/websocket_dev.h

Issue 9296001: WebSocket Pepper API: Remove binary type handling interfaces (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/c/dev/ppb_websocket_dev.h ('k') | ppapi/cpp/dev/websocket_dev.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/dev/websocket_dev.h
diff --git a/ppapi/cpp/dev/websocket_dev.h b/ppapi/cpp/dev/websocket_dev.h
index 2c55d51586b4ba0f43f6ee8e6b8647c933844a9c..e1de5362380a48f1f82e32b3f8096d116f5d45bc 100644
--- a/ppapi/cpp/dev/websocket_dev.h
+++ b/ppapi/cpp/dev/websocket_dev.h
@@ -87,7 +87,8 @@ class WebSocket_Dev : public Resource {
///
/// @param[out] message The received message is copied to provided
/// <code>message</code>. The <code>message</code> must remain valid until
- /// the ReceiveMessage operation completes.
+ /// the ReceiveMessage operation completes. It will be a <code>Var</code> of
+ /// string or ArrayBuffer types on receiving.
/// @param[in] callback A <code>CompletionCallback</code> which is called
/// when the receiving message is completed. It is ignored if ReceiveMessage
/// completes synchronously and returns <code>PP_OK</code>.
@@ -105,7 +106,8 @@ class WebSocket_Dev : public Resource {
///
/// @param[in] data A message to send. The message is copied to internal
/// buffer. So caller can free <code>data</code> safely after returning
- /// from the function.
+ /// from the function. It must be a <code>Var</code> of string or ArrayBuffer
+ /// types.
///
/// @return An int32_t containing an error code from
/// <code>pp_errors.h</code>.
@@ -176,33 +178,6 @@ class WebSocket_Dev : public Resource {
/// @return Returns a <code>Var</code> of string type. If called before the
/// connection is established, it contains the empty string.
Var GetURL();
-
- /// SetBinaryType() specifies the binary object type for receiving binary
- /// frames representation. Receiving text frames are always mapped to
- /// <PP_VARTYPE_STRING</code> var regardless of this attribute.
- /// This function should be called before Connect() to ensure receiving all
- /// incoming binary frames as the specified binary object type.
- /// Default type is <code>PP_WEBSOCKETBINARYTYPE_BLOB_DEV</code>.
- ///
- /// Currently, Blob bindings is not supported in Pepper, so receiving binary
- /// type is always ArrayBuffer. To ensure backward compatibility, you must
- /// call this function with
- /// <code>PP_WEBSOCKETBINARYTYPE_ARRAYBUFFER_DEV</code> to use binary frames.
- ///
- /// @param[in] binary_type Binary object type for receiving binary frames
- /// representation.
- ///
- /// @return Returns <code>false</code> if the specified type is not
- /// supported. Otherwise, returns <code>true</code>.
- ///
- bool SetBinaryType(PP_WebSocketBinaryType_Dev binary_type);
-
- /// GetBinaryType() returns the currently specified binary object type for
- /// receiving binary frames.
- ///
- /// @return Returns <code>PP_WebSocketBinaryType_Dev</code> represents the
- /// current binary object type.
- PP_WebSocketBinaryType_Dev GetBinaryType();
};
} // namespace pp
« no previous file with comments | « ppapi/c/dev/ppb_websocket_dev.h ('k') | ppapi/cpp/dev/websocket_dev.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698